Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Feb 5, 2021

PR Summary

When output is redirected, Write-Progress rendering of the ConsoleHost tries to hide the cursor (or show the cursor) which throws an exception. Fix is to not render any progress at all if output is redirected as it's likely used for automation anyways.

The Disconnect test seems to be failing where it validates the session is in a Disconnected state, but typically has been in a Disconnecting state. Updated test to handle both Disconnected and Disconnecting to allow it to pass.

Markdown URL link tests sometimes fail when the 3rd party site timesout. Added a status code to see what is being returned and whether we should allow that to pass.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Feb 5, 2021
@SteveL-MSFT SteveL-MSFT changed the title Adjust timing of Disconnect test Fix robustness of Disconnect and WinCompat tests Feb 5, 2021
@SteveL-MSFT SteveL-MSFT changed the title Fix robustness of Disconnect and WinCompat tests Suppress Write-Progress in ConsoleHost if output is redirected and fix tests Feb 6, 2021
@daxian-dbw daxian-dbw merged commit 6d7fbed into PowerShell:master Feb 8, 2021
@anmenaga anmenaga added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 8, 2021
@SteveL-MSFT SteveL-MSFT deleted the disconnect-test branch February 9, 2021 22:09
@ghost
Copy link

ghost commented Feb 12, 2021

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants