Suppress Write-Progress in ConsoleHost if output is redirected and fix tests #14716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When output is redirected, Write-Progress rendering of the ConsoleHost tries to hide the cursor (or show the cursor) which throws an exception. Fix is to not render any progress at all if output is redirected as it's likely used for automation anyways.
The Disconnect test seems to be failing where it validates the session is in a
Disconnectedstate, but typically has been in aDisconnectingstate. Updated test to handle bothDisconnectedandDisconnectingto allow it to pass.Markdown URL link tests sometimes fail when the 3rd party site timesout. Added a status code to see what is being returned and whether we should allow that to pass.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.