Skip to content

Make universal Deb package based on deb package spec #14681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 2 commits into from
Feb 2, 2021
Merged

Make universal Deb package based on deb package spec #14681

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8120e27
test changes based on deb spec
TravisEz13 Jan 29, 2021
a8f82e5
Update tools/packaging/packaging.psm1
TravisEz13 Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions tools/packaging/packaging.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,17 +1270,11 @@ function Get-PackageDependencies
"libgssapi-krb5-2",
"liblttng-ust0",
"libstdc++6",
"zlib1g"
"zlib1g",
"libicu72|libicu71|libicu70|libicu69|libicu68|libicu67|libicu66|libicu65|libicu63|libicu60|libicu57|libicu55|libicu52",
"libssl1.1|libssl1.0.2|libssl1.0.0"
Copy link
Collaborator

@JamesWTruher JamesWTruher Jan 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this change it looks like we are eliminating the unsupported error when faced with a platform we don't understand. Does that mean we are relying on an error generated when the dependency is not found rather than a specific version?

Copy link
Member Author

@TravisEz13 TravisEz13 Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, basically, but that was only a build time error. Since the attempt here is to build a universal, package, keeping the error didn't make since.

If we hit a platform that has a missing dependency, then we should add it to the list if supported or not if the platform is not.

)

switch -regex ($Distribution) {
"ubuntu\.16\.04" { $Dependencies += @("libssl1.0.0", "libicu55") }
"ubuntu\.18\.04" { $Dependencies += @("libssl1.0.0", "libicu60") }
"ubuntu\.20\.04" { $Dependencies += @("libssl1.1", "libicu66") }
"debian\.9" { $Dependencies += @("libssl1.0.2", "libicu57") }
"debian\.(10|11)" { $Dependencies += @("libssl1.1", "libicu63") }
default { throw "Debian distro '$Distribution' is not supported." }
}
} elseif ($Environment.IsRedHatFamily) {
$Dependencies = @(
"openssl-libs",
Expand Down