-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix splatting being treated as positional parameter #14623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix splatting being treated as positional parameter #14623
Conversation
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Holt <rjmholt@gmail.com>
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
rkeithhill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the code complexity check that is failing
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Holt <rjmholt@gmail.com>
|
🎉 Handy links: |
PR Summary
Fixes #3650 where if you use splatting it counts as a positional argument so you lose the parameter in the tab completion suggestions.
For example
Get-ChildItem @Splat -Pwon't suggest the Path parameter because @Splat is incorrectly being treated as a value for the Path parameter.PR Context
It's annoying to forget about a parameter because IntelliSense didn't show it to you.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.