This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@PoshChan please retry macos

@bergmeister, did not find matching build context: PowerShell-CI-macOS; allowed contexts: PowerShell-CI-SSH

@bergmeister can you rebase and force push to force rerunning CI?

Edit: Nevermind, got it restarted.

This is much more an Interactive UX decision than core cmdlets and personally whilst I can see where @iSazonov is coming from re the "dead code" we cannot be sure that PowerShell is not already being used with that amount of data via web requests, plus we also have a need to ensure that we also future proof PowerShell as we go, as not to need an additional PR to implement them in future.

Therefore I'd happily approve this PR on behalf of the Interactive UX Working Group.

I would however ask to see the differences in end package size to this PR and one based on the comments that @iSazonov is concerned about because honestly I can't see it making enough of a difference to not allow this PR through as it is

@bergmeister I know it's been a long time, and you may have lost the interest in updating this PR. But, if not, could you please address #14611 (comment)? Or, I can help updating the PR.

This PR has 81 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Label      : Small
Size       : +60 -21
Percentile : 32.4%

Total files changed: 7

Change summary by file extension:
.cs : +56 -17
.resx : +4 -4

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@bergmeister I know it's been a long time, and you may have lost the interest in updating this PR. But, if not, could you please address #14611 (comment)? Or, I can help updating the PR.

Definitely still interested, I just addressed that comment from Keith that you wanted me to do e8532db

@daxian-dbw Have you already looked at the animation in the description of this PR or have you done an actual experiment? Do you see how the bar flickers? How the scale changes? After that, do you really think it's great UX? This is a nightmare.

@iSazonov I built and played with the changes in this PR, and it looks pretty nice to me. As for the blinking cursor bar, that's out of the scope of this PR, but something powershell can handle, for example, make the cursor invisible when rendering the progress bar.

How the scale changes? After that, do you really think it's great UX? This is a nightmare.

I'm not sure what you mean by "scale changes", but the new UX is much better than the old UX in my opinion.

Old Classic and Minimal View

New Classic and Minimal View

@daxian-dbw Could you please also share screenshots for bytes, TB and PB too? I would really like to see how this code works.

If it can't be done, why this dead code? MB is the only thing we need.

I agree it should be super rare to download a package with the TB or PB size, but I'm fine keeping those switch branches in DisplayHumanReadableFileSize for completeness, because:

1. Those switch branches are very simple, and thus won't cause any problem to maintenance.
2. You can never say for 100% that no one will download a package with such large size. Maybe someone is using a Terabit Ethernet, and then downloading a TB/PB size package may not be that impossible :)

@daxian-dbw Could you please also share screenshots for bytes, TB and PB too? I would really like to see how this code works.

If it can't be done, why this dead code? MB is the only thing we need.

@iSazonov, I'm not sure that this comment is useful, especially considering that we aren't just trying to get rid of "dead code" but trying to have code that is useful now and in the future too

@iSazonov Given the discussion above, I will merge this PR as is.

Have these updates been cancelled?
I'm using the latest version of PowerShell but still getting bytes instead of the handy human display in megabytes

@VozdyxDev Glad you're looking forward to using this feature. This feature didn't make it into 7.3 because it was too close to its release from a testing/risk perspective. It is in the preview of 7.4 though if you already want to use it.

Oh, thanks for the info)