Skip to content

Enable IDE0077: LegacyFormatSuppressMessageAttribute #14495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Jan 7, 2021
Merged

Enable IDE0077: LegacyFormatSuppressMessageAttribute #14495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ dotnet_diagnostic.IDE0075.severity = warning
dotnet_diagnostic.IDE0076.severity = silent

# IDE0077: LegacyFormatSuppressMessageAttribute
dotnet_diagnostic.IDE0077.severity = silent
dotnet_diagnostic.IDE0077.severity = warning

# IDE0078: UsePatternCombinators
dotnet_diagnostic.IDE0078.severity = silent
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.Commands.Utility/commands/utility/UtilityCommon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
using System.Management.Automation;
using System.Text;

[module: SuppressMessage("Microsoft.Naming", "CA1711:IdentifiersShouldNotHaveIncorrectSuffix", Scope = "type", Target = "Microsoft.PowerShell.Commands.ByteCollection")]
[module: SuppressMessage("Microsoft.Naming", "CA1711:IdentifiersShouldNotHaveIncorrectSuffix", Scope = "type", Target = "~T:Microsoft.PowerShell.Commands.ByteCollection")]
Copy link
Collaborator

@iSazonov iSazonov Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the suppression?

Copy link
Contributor Author

@xtqqczze xtqqczze Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we enable the rule and remove the suppression we get:

Error CA1711 Rename type name ByteCollection so that it does not end in 'Collection' Microsoft.PowerShell.Commands.Utility src\Microsoft.PowerShell.Commands.Utility\commands\utility\UtilityCommon.cs 99 Active


namespace Microsoft.PowerShell.Commands
{
Expand Down