Skip to content

Enable IDE0049: PreferBuiltInOrFrameworkType #14491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 3 commits into from
Jul 28, 2021
Merged

Enable IDE0049: PreferBuiltInOrFrameworkType #14491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b63a2b
Enable IDE0049: PreferBuiltInOrFrameworkType
xtqqczze Dec 23, 2020
74c62d0
revert uncompiled files
xtqqczze Jun 22, 2021
2f672ed
Merge branch 'master' into IDE0049
xtqqczze Jun 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ dotnet_diagnostic.IDE0048.severity = suggestion

# IDE0049: PreferBuiltInOrFrameworkType
# https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0049
dotnet_diagnostic.IDE0049.severity = silent
dotnet_diagnostic.IDE0049.severity = warning

# IDE0050: ConvertAnonymousTypeToTuple
# https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0050
Expand Down
10 changes: 5 additions & 5 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimCommandBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ internal class ParameterSetEntry
/// Initializes a new instance of the <see cref="ParameterSetEntry"/> class.
/// </summary>
/// <param name="mandatoryParameterCount"></param>
internal ParameterSetEntry(UInt32 mandatoryParameterCount)
internal ParameterSetEntry(uint mandatoryParameterCount)
{
this.MandatoryParameterCount = mandatoryParameterCount;
this.IsDefaultParameterSet = false;
Expand All @@ -80,7 +80,7 @@ internal ParameterSetEntry(ParameterSetEntry toClone)
/// </summary>
/// <param name="mandatoryParameterCount"></param>
/// <param name="mandatory"></param>
internal ParameterSetEntry(UInt32 mandatoryParameterCount, bool isDefault)
internal ParameterSetEntry(uint mandatoryParameterCount, bool isDefault)
{
this.MandatoryParameterCount = mandatoryParameterCount;
this.IsDefaultParameterSet = isDefault;
Expand All @@ -104,7 +104,7 @@ internal void reset()
/// <summary>
/// Property <c>MandatoryParameterCount</c>
/// </summary>
internal UInt32 MandatoryParameterCount { get; } = 0;
internal uint MandatoryParameterCount { get; } = 0;

/// <summary>
/// Property <c>IsValueSet</c>
Expand All @@ -119,12 +119,12 @@ internal void reset()
/// <summary>
/// Property <c>SetMandatoryParameterCount</c>
/// </summary>
internal UInt32 SetMandatoryParameterCount { get; set; } = 0;
internal uint SetMandatoryParameterCount { get; set; } = 0;

/// <summary>
/// Property <c>SetMandatoryParameterCountAtBeginProcess</c>
/// </summary>
internal UInt32 SetMandatoryParameterCountAtBeginProcess { get; set; } = 0;
internal uint SetMandatoryParameterCountAtBeginProcess { get; set; } = 0;
}

/// <summary>
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimIndicationWatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ public CimIndicationWatcher(
string theNamespace,
string queryDialect,
string queryExpression,
UInt32 operationTimeout)
uint operationTimeout)
{
ValidationHelper.ValidateNoNullorWhiteSpaceArgument(queryExpression, queryExpressionParameterName);
computerName = ConstValue.GetComputerName(computerName);
Expand All @@ -173,7 +173,7 @@ public CimIndicationWatcher(
string theNamespace,
string queryDialect,
string queryExpression,
UInt32 operationTimeout)
uint operationTimeout)
{
ValidationHelper.ValidateNoNullorWhiteSpaceArgument(queryExpression, queryExpressionParameterName);
ValidationHelper.ValidateNoNullArgument(cimSession, cimSessionParameterName);
Expand All @@ -192,7 +192,7 @@ private void Initialize(
string theNameSpace,
string theQueryDialect,
string theQueryExpression,
UInt32 theOperationTimeout)
uint theOperationTimeout)
{
enableRaisingEvents = false;
status = Status.Default;
Expand Down Expand Up @@ -378,7 +378,7 @@ internal void SetCmdlet(Cmdlet cmdlet)
private string nameSpace;
private string queryDialect;
private string queryExpression;
private UInt32 operationTimeout;
private uint operationTimeout;
#endregion
#endregion
}
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimRegisterCimIndication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public void RegisterCimIndication(
string nameSpace,
string queryDialect,
string queryExpression,
UInt32 operationTimeout)
uint operationTimeout)
{
DebugHelper.WriteLogEx("queryDialect = '{0}'; queryExpression = '{1}'", 0, queryDialect, queryExpression);
this.TargetComputerName = computerName;
Expand All @@ -146,7 +146,7 @@ public void RegisterCimIndication(
string nameSpace,
string queryDialect,
string queryExpression,
UInt32 operationTimeout)
uint operationTimeout)
{
DebugHelper.WriteLogEx("queryDialect = '{0}'; queryExpression = '{1}'", 0, queryDialect, queryExpression);
if (cimSession == null)
Expand Down Expand Up @@ -317,7 +317,7 @@ internal string TargetComputerName
/// <returns></returns>
private CimSessionProxy CreateSessionProxy(
string computerName,
UInt32 timeout)
uint timeout)
{
CimSessionProxy proxy = CreateCimSessionProxy(computerName);
proxy.OperationTimeout = timeout;
Expand All @@ -332,7 +332,7 @@ private CimSessionProxy CreateSessionProxy(
/// <returns></returns>
private CimSessionProxy CreateSessionProxy(
CimSession session,
UInt32 timeout)
uint timeout)
{
CimSessionProxy proxy = CreateCimSessionProxy(session);
proxy.OperationTimeout = timeout;
Expand Down
16 changes: 8 additions & 8 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimSessionProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,11 +542,11 @@ private void CreateSetSession(
/// <summary>
/// Set timeout value (seconds) of the operation.
/// </summary>
public UInt32 OperationTimeout
public uint OperationTimeout
{
get
{
return (UInt32)this.OperationOptions.Timeout.TotalSeconds;
return (uint)this.OperationOptions.Timeout.TotalSeconds;
}

set
Expand Down Expand Up @@ -821,7 +821,7 @@ private void FireOperationDeletedEvent(
/// </summary>
/// <param name="channel"></param>
/// <param name="message"></param>
internal void WriteMessage(UInt32 channel, string message)
internal void WriteMessage(uint channel, string message)
{
DebugHelper.WriteLogEx("Channel = {0} message = {1}", 0, channel, message);
try
Expand Down Expand Up @@ -863,7 +863,7 @@ internal void WriteOperationStartMessage(string operation, Hashtable parameterLi
CimCmdletStrings.CimOperationStart,
operation,
(parameters.Length == 0) ? "null" : parameters.ToString());
WriteMessage((UInt32)CimWriteMessageChannel.Verbose, operationStartMessage);
WriteMessage((uint)CimWriteMessageChannel.Verbose, operationStartMessage);
}

/// <summary>
Expand All @@ -878,7 +878,7 @@ internal void WriteOperationCompleteMessage(string operation)
string operationCompleteMessage = string.Format(CultureInfo.CurrentUICulture,
CimCmdletStrings.CimOperationCompleted,
operation);
WriteMessage((UInt32)CimWriteMessageChannel.Verbose, operationCompleteMessage);
WriteMessage((uint)CimWriteMessageChannel.Verbose, operationCompleteMessage);
}

/// <summary>
Expand All @@ -894,8 +894,8 @@ internal void WriteOperationCompleteMessage(string operation)
public void WriteProgress(string activity,
string currentOperation,
string statusDescription,
UInt32 percentageCompleted,
UInt32 secondsRemaining)
uint percentageCompleted,
uint secondsRemaining)
{
DebugHelper.WriteLogEx("activity:{0}; currentOperation:{1}; percentageCompleted:{2}; secondsRemaining:{3}",
0, activity, currentOperation, percentageCompleted, secondsRemaining);
Expand Down Expand Up @@ -1879,7 +1879,7 @@ private CimSession CreateCimSessionByComputerName(string computerName)
/// <param name="credential"></param>
/// <returns></returns>
internal static CimSessionOptions CreateCimSessionOption(string computerName,
UInt32 timeout, CimCredential credential)
uint timeout, CimCredential credential)
{
DebugHelper.WriteLogEx();

Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimWriteMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ internal sealed class CimWriteMessage : CimBaseAction

#region Properties

internal UInt32 Channel { get; }
internal uint Channel { get; }

internal string Message { get; }

Expand All @@ -35,7 +35,7 @@ internal sealed class CimWriteMessage : CimBaseAction
/// <summary>
/// Initializes a new instance of the <see cref="CimWriteMessage"/> class.
/// </summary>
public CimWriteMessage(UInt32 channel,
public CimWriteMessage(uint channel,
string message)
{
this.Channel = channel;
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimWriteProgress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ public CimWriteProgress(
int theActivityID,
string theCurrentOperation,
string theStatusDescription,
UInt32 thePercentageCompleted,
UInt32 theSecondsRemaining)
uint thePercentageCompleted,
uint theSecondsRemaining)
{
this.Activity = theActivity;
this.ActivityID = theActivityID;
Expand Down Expand Up @@ -112,12 +112,12 @@ public override void Execute(CmdletOperationBase cmdlet)
/// <summary>
/// Gets the percentage completed of the given activity.
/// </summary>
internal UInt32 PercentageCompleted { get; }
internal uint PercentageCompleted { get; }

/// <summary>
/// Gets the number of seconds remaining for the given activity.
/// </summary>
internal UInt32 SecondsRemaining { get; }
internal uint SecondsRemaining { get; }

#endregion
}
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimAssociatedInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public CimInstance InputObject
/// </summary>
[Alias(AliasOT)]
[Parameter(ValueFromPipelineByPropertyName = true)]
public UInt32 OperationTimeoutSec { get; set; }
public uint OperationTimeoutSec { get; set; }

/// <summary>
/// <para>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimClassCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public GetCimClassCommand()
/// </summary>
[Alias(AliasOT)]
[Parameter(ValueFromPipelineByPropertyName = true)]
public UInt32 OperationTimeoutSec { get; set; }
public uint OperationTimeoutSec { get; set; }

/// <summary>
/// The following is the definition of the input parameter "Session".
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ public string Namespace
/// </summary>
[Alias(AliasOT)]
[Parameter]
public UInt32 OperationTimeoutSec { get; set; }
public uint OperationTimeoutSec { get; set; }

/// <summary>
/// <para>The following is the definition of the input parameter "InputObject".
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimSessionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public string[] ComputerName
ValueFromPipelineByPropertyName = true,
ParameterSetName = SessionIdSet)]
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public UInt32[] Id
public uint[] Id
{
get
{
Expand All @@ -95,7 +95,7 @@ public UInt32[] Id
}
}

private UInt32[] id;
private uint[] id;

/// <summary>
/// The following is the definition of the input parameter "InstanceID".
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/InvokeCimMethodCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ public string Namespace
/// </summary>
[Alias(AliasOT)]
[Parameter]
public UInt32 OperationTimeoutSec { get; set; }
public uint OperationTimeoutSec { get; set; }

#endregion

Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/NewCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public string Namespace
/// </summary>
[Alias(AliasOT)]
[Parameter]
public UInt32 OperationTimeoutSec { get; set; }
public uint OperationTimeoutSec { get; set; }

/// <summary>
/// <para>
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/NewCimSessionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public PasswordAuthenticationMechanism Authentication
/// </summary>
[Alias(AliasOT)]
[Parameter(ValueFromPipelineByPropertyName = true)]
public UInt32 OperationTimeoutSec
public uint OperationTimeoutSec
{
get
{
Expand All @@ -118,7 +118,7 @@ public UInt32 OperationTimeoutSec
}
}

private UInt32 operationTimeout;
private uint operationTimeout;
internal bool operationTimeoutSet = false;

/// <summary>
Expand All @@ -136,7 +136,7 @@ public UInt32 OperationTimeoutSec
/// This is specificly for wsman protocol.
/// </summary>
[Parameter(ValueFromPipelineByPropertyName = true)]
public UInt32 Port
public uint Port
{
get
{
Expand All @@ -150,7 +150,7 @@ public UInt32 Port
}
}

private UInt32 port;
private uint port;
private bool portSet = false;

/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/NewCimSessionOptionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ public Uri HttpPrefix
/// </summary>
[Parameter(ValueFromPipelineByPropertyName = true,
ParameterSetName = WSManParameterSet)]
public UInt32 MaxEnvelopeSizeKB
public uint MaxEnvelopeSizeKB
{
get
{
Expand All @@ -246,7 +246,7 @@ public UInt32 MaxEnvelopeSizeKB
}
}

private UInt32 maxenvelopesizekb;
private uint maxenvelopesizekb;
private bool maxenvelopesizekbSet = false;

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/RegisterCimIndicationCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public string QueryDialect
/// </summary>
[Alias(CimBaseCommand.AliasOT)]
[Parameter]
public UInt32 OperationTimeoutSec { get; set; }
public uint OperationTimeoutSec { get; set; }

/// <summary>
/// The following is the definition of the input parameter "Session".
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/RemoveCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public string Namespace
/// </summary>
[Alias(AliasOT)]
[Parameter]
public UInt32 OperationTimeoutSec { get; set; }
public uint OperationTimeoutSec { get; set; }

/// <summary>
/// The following is the definition of the input parameter "InputObject".
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/RemoveCimSessionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public string[] ComputerName
ValueFromPipelineByPropertyName = true,
ParameterSetName = SessionIdSet)]
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public UInt32[] Id
public uint[] Id
{
get
{
Expand All @@ -122,7 +122,7 @@ public UInt32[] Id
}
}

private UInt32[] id;
private uint[] id;

/// <summary>
/// The following is the definition of the input parameter "InstanceId".
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/SetCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public string Namespace
/// </summary>
[Alias(AliasOT)]
[Parameter]
public UInt32 OperationTimeoutSec { get; set; }
public uint OperationTimeoutSec { get; set; }

/// <summary>
/// The following is the definition of the input parameter "InputObject".
Expand Down
Loading