Skip to content

Add manual release automation steps and improve changelog script #14445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 3 commits into from
Jan 21, 2021
Merged

Add manual release automation steps and improve changelog script #14445

daxian-dbw merged 3 commits into from
Jan 21, 2021

Conversation

@rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Dec 16, 2020

PR Summary

In three separate commits, this PR:

  • Fixes the changelog script so that the PR related to a commit is only taken from the end of the commit message (@vexx32 the existing script didn't like your recent commit messages -- this change means the changelog script will work with them, although we'll take out the issue link anyway)
  • Adds a manual step for MSIX publication
  • Adds a manual step for winget publication

Let me know if there are other steps I can/should capture in the changes here.

One change I haven't made is for the global tool validation logic with preview builds, since I don't know what the story there is.

PR Context

During the last release I encountered a couple of issues and this PR represents some small fixes to help some of those issues.

PR Checklist

@ghost ghost assigned daxian-dbw Dec 16, 2020
@vexx32
Copy link
Collaborator

vexx32 commented Dec 16, 2020

(@vexx32 the existing script didn't like your recent commit messages -- this change means the changelog script will work with them, although we'll take out the issue link anyway)

Hey, someone's gotta break it. 😁

@rjmholt
Copy link
Collaborator Author

rjmholt commented Dec 17, 2020

Hey, someone's gotta break it. 😁

Absolutely -- I broke it by putting || in a commit message once

@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 17, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 24, 2020
@ghost
Copy link

ghost commented Dec 24, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@anmenaga
Copy link

anmenaga commented Jan 11, 2021 •
edited
Loading

Absolutely -- I broke it by putting || in a commit message once

I remember similar character in a PR subject broke change list generation during a release some time ago... :)

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 11, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 19, 2021
@ghost
Copy link

ghost commented Jan 19, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw daxian-dbw merged commit 6eee69b into PowerShell:master Jan 21, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 21, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 26, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 11, 2021
@rjmholt @adityapatwardhan
Add manual release automation steps and improve changelog script (Pow…
129257e 
…erShell#14445)
@ghost
Copy link

ghost commented Mar 11, 2021

🎉v7.0.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Mar 11, 2021

🎉v7.1.3 has been released which incorporates this pull request.:tada:

Handy links:

WamWooWam pushed a commit to WamWooWam/PowerShell that referenced this pull request Mar 16, 2021
@rjmholt @adityapatwardhan
Add manual release automation steps and improve changelog script (Pow…
ed7137f 
…erShell#14445)
WamWooWam added a commit to WamWooWam/PowerShell that referenced this pull request Mar 16, 2021
@WamWooWam
Merge tag 'v7.1.3' into powercord
3cc3e1d 
[7.1.3] - 2021-03-11

*** Engine Updates and Fixes

- Remove the 32K character limit on the environment block for `Start-Process` (PowerShell#14111)
- Fix webcmdlets to properly construct URI from body when using `-NoProxy` (PowerShell#14673)

*** General Cmdlet Updates and Fixes

- Fix `PromptForCredential()` to add `targetName` as domain (PowerShell#14504)

*** Build and Packaging Improvements

<details>

<summary>

Bump .NET SDK to 5.0.4

</summary>

<ul>
<li>Bump .NET SDK to 5.0.4 (Internal 14775)</li>
<li>Disable running markdown link verification in release build CI (PowerShell#14971, PowerShell#14974, PowerShell#14975)</li>
<li>Use template that disables component governance for CI (PowerShell#14938)</li>
<li>Declare which variable group is used for checking the blob in the release build (PowerShell#14970)</li>
<li>Add suppress for nuget multi-feed warning (PowerShell#14893)</li>
<li>Disable code signing validation where the file type is not supported (PowerShell#14885)</li>
<li>Install wget on <code>CentOS</code> 7 docker image (PowerShell#14857)</li>
<li>Fix install-dotnet download (PowerShell#14856)</li>
<li>Make universal Deb package based on deb package spec (PowerShell#14681)</li>
<li>Fix release build to upload global tool packages to artifacts (PowerShell#14620)</li>
<li>Update <code>ini</code> component version in test <code>package.json</code> (PowerShell#14454)</li>
<li>Add manual release automation steps and improve changelog script (PowerShell#14445)</li>
<li>Update markdown test packages with security fixes (PowerShell#14145)</li>
<li>Fix a typo in the <code>Get-ChangeLog</code> function (PowerShell#14129)</li>
<li>Disable global tool copy to unblock release</li>
</ul>

</details>

[7.1.3]: PowerShell/PowerShell@v7.1.2...v7.1.3
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

1 more reviewer

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw daxian-dbw

Labels

Backport-7.0.x-Done BackPort-7.1.x-Done Backport to 7.1.x completed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

6 participants

@rjmholt @vexx32 @anmenaga @daxian-dbw @adityapatwardhan @iSazonov