DO NOT MERGE: 7.2.0-preview.2 changes #14433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Robert Holt <rjmholt@gmail.com>
Add CHANGELOG for 7.2.0-preview.2
…kage Fix release pipeline by skipping the global tool package
rjmholt
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
ghost
assigned
Collaborator
Author
|
Once this is approved I'll need to create a merge commit manually |
daxian-dbw
reviewed
Dec 16, 2020
Member
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
For changes except for the changelog, do we need to take them back?
| $globalToolPath = "$ENV:PIPELINE_WORKSPACE/releasePipeline/finalResults/PowerShell.$releaseVersion.nupkg" | ||
| ### -WhatIf to make sure we do not release global tool. Remove -WhatIf when the PowerShell name reservation is done. | ||
| Copy-Item $globalToolPath -Destination "$(Pipeline.Workspace)/release" -WhatIf | ||
| ### Copy-Item $globalToolPath -Destination "$(Pipeline.Workspace)/release" -WhatIf |
Member
There was a problem hiding this comment.
Shall this change be taken back to GH master?
Collaborator
Author
There was a problem hiding this comment.
Seems like it shouldn't be -- I'll remove it
Collaborator
Author
|
Closed in favour of #14434 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Changes made for the 7.2.0-preview.2 release.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.