Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Dec 14, 2020

PR Summary

On Windows, some popular native commands (like those shipped with Git) will disable console VT mode and doesn't set it back upon execution. When the prompt comes back, you see escape sequence characters instead of rendered text. Fix is to check if VT mode was previously enabled and try turning it back on.

PR Context

Fix #14360

PR Checklist

@ghost ghost assigned anmenaga Dec 14, 2020
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 16, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 24, 2020
@ghost
Copy link

ghost commented Dec 24, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@drichardson
Copy link

drichardson commented Feb 26, 2021

Any chance this could get a review from someone with write access? This change has been waiting for review for a few months now.

Copy link

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmenaga anmenaga removed the Review - Needed The PR is being reviewed label Mar 10, 2021
@anmenaga anmenaga merged commit cbd97d0 into PowerShell:master Mar 10, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.4 milestone Mar 10, 2021
@SteveL-MSFT SteveL-MSFT deleted the reset-vt branch March 10, 2021 22:51
@ghost
Copy link

ghost commented Mar 16, 2021

🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ANSI escape codes in prompt incorrectly rendered in some cases

6 participants