-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Re-enable VT mode on Windows after running command in ConsoleHost #14413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
Any chance this could get a review from someone with write access? This change has been waiting for review for a few months now. |
anmenaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 Handy links: |
PR Summary
On Windows, some popular native commands (like those shipped with Git) will disable console VT mode and doesn't set it back upon execution. When the prompt comes back, you see escape sequence characters instead of rendered text. Fix is to check if VT mode was previously enabled and try turning it back on.
PR Context
Fix #14360
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.