Skip to content

Fix RCS1215: Expression is always equal to true/false #14356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Jan 19, 2021
Merged

Fix RCS1215: Expression is always equal to true/false #14356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa924e
Fix RCS1215: Expression is always equal to true/false
xtqqczze Dec 9, 2020
c691d9d
cleanup
xtqqczze Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ protected bool DoesProviderSupportShouldProcess(string[] paths)
// may be getting piped in.
bool result = true;

if (paths != null && paths.Length >= 0)
if (paths != null)
{
foreach (string path in paths)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePromptForChoice.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ public Collection<int> PromptForChoice(string caption,
// choices to be picked.

// user did not pick up any choices..choose the default
if ((result.Count == 0) && (defaultChoiceKeys.Keys.Count >= 0))
if (result.Count == 0)
{
// if there's a default, pick that one.
foreach (int defaultChoice in defaultChoiceKeys.Keys)
Expand Down
6 changes: 2 additions & 4 deletions src/Microsoft.PowerShell.Security/security/CertificateProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2017,16 +2017,14 @@ private object GetItemAtPath(string path, bool test, out bool isContainer)
//
// Thus lengths 1 & 2 are container items.
//
isContainer = (pathElements.Length >= 0) &&
(pathElements.Length <= 2);
isContainer = pathElements.Length <= 2;

X509NativeStore store = null;

//
// handle invalid path depth
//
if ((pathElements.Length > 3) ||
(pathElements.Length < 0))
if (pathElements.Length > 3)
{
if (test)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@ private Collection<int> EmulatePromptForMultipleChoice(string caption,
// choices to be picked.

// user did not pick up any choices..choose the default
if ((result.Count == 0) && (defaultChoiceKeys.Keys.Count >= 0))
if (result.Count == 0)
{
// if there's a default, pick that one.
foreach (int defaultChoice in defaultChoiceKeys.Keys)
Expand Down