Skip to content

Make AppLocker Enforce mode take precedence over UMCI Audit mode #14353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 3 commits into from
Dec 9, 2020
Merged

Make AppLocker Enforce mode take precedence over UMCI Audit mode #14353

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3d4d36
Fix issue where AppLocker Enforce mode is ignored if UMCI audit mode …
TravisEz13 Dec 8, 2020
15406ae
fix variable names
TravisEz13 Dec 8, 2020
4cb3f4b
Update src/System.Management.Automation/security/wldpNativeMethods.cs
TravisEz13 Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions src/System.Management.Automation/security/wldpNativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,36 +78,39 @@ public static SystemEnforcementMode GetSystemLockdownPolicy()
/// <returns>An EnforcementMode that describes policy.</returns>
public static SystemEnforcementMode GetLockdownPolicy(string path, SafeHandle handle)
{
// Check the WLDP API
SystemEnforcementMode lockdownPolicy = GetWldpPolicy(path, handle);
if (lockdownPolicy == SystemEnforcementMode.Enforce)
// Check the WLDP File policy via API
var wldpFilePolicy = GetWldpPolicy(path, handle);
if (wldpFilePolicy == SystemEnforcementMode.Enforce)
{
return lockdownPolicy;
return wldpFilePolicy;
}

// Check the AppLocker File policy via API
// This needs to be checked before WLDP audit policy
// So, that we don't end up in Audit mode,
// when we should be enforce mode.
var appLockerFilePolicy = GetAppLockerPolicy(path, handle);
if (appLockerFilePolicy == SystemEnforcementMode.Enforce)
{
return appLockerFilePolicy;
}

// At this point, LockdownPolicy = Audit or Allowed.
// If there was a WLDP policy, but WLDP didn't block it,
// then it was explicitly allowed. Therefore, return the result for the file.
SystemEnforcementMode systemWldpPolicy = s_cachedWldpSystemPolicy.GetValueOrDefault(SystemEnforcementMode.None);
if ((systemWldpPolicy == SystemEnforcementMode.Enforce) ||
(systemWldpPolicy == SystemEnforcementMode.Audit))
{
return lockdownPolicy;
}

// Check the AppLocker API
lockdownPolicy = GetAppLockerPolicy(path, handle);
if (lockdownPolicy == SystemEnforcementMode.Enforce)
if ((systemWldpPolicy == SystemEnforcementMode.Audit) ||
(systemWldpPolicy == SystemEnforcementMode.Enforce))
{
return lockdownPolicy;
return wldpFilePolicy;
}

// If there was a system-wide AppLocker policy, but AppLocker didn't block it,
// then return AppLocker's status.
if (s_cachedSaferSystemPolicy.GetValueOrDefault(SaferPolicy.Allowed) ==
SaferPolicy.Disallowed)
{
return lockdownPolicy;
return appLockerFilePolicy;
}

// If it's not set to 'Enforce' by the platform, allow debug overrides
Expand Down