Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 6, 2020

@ghost ghost assigned rjmholt Dec 6, 2020
@xtqqczze xtqqczze changed the title WIP: Fix RCS1102: Make class static Fix RCS1102: Make class static Dec 10, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 10, 2020 00:02
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 17, 2020
@ghost
Copy link

ghost commented Dec 17, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

@iSazonov Could you please review?

@iSazonov
Copy link
Collaborator

@xtqqczze Can you add more information why we need this? What are the benefits we get?
This looks like a formal cosmetic change.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 22, 2020
@xtqqczze
Copy link
Contributor Author

Closed in favour of #14483.

@xtqqczze xtqqczze closed this Dec 23, 2020
@xtqqczze xtqqczze deleted the RCS1102 branch December 24, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants