Skip to content

Upgrade StyleCopAnalyzers to v1.2.0-beta.304 #14333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xtqqczze wants to merge 1 commit into from
Closed

Upgrade StyleCopAnalyzers to v1.2.0-beta.304 #14333

xtqqczze wants to merge 1 commit into from

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 6, 2020

@ghost ghost assigned adityapatwardhan Dec 6, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 6, 2020

@iSazonov Can we use dependabot to check for StyleCopAnalyzers updates?

@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Dec 6, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 6, 2020 16:34
@iSazonov
Copy link
Collaborator

iSazonov commented Dec 6, 2020

@iSazonov Can we use dependabot to check for StyleCopAnalyzers updates?

Why not? :-)

/cc @RDIL Thoughts?

@RDIL
Copy link
Contributor

RDIL commented Dec 7, 2020

@iSazonov Can we use dependabot to check for StyleCopAnalyzers updates?

Why not? :-)

/cc @RDIL Thoughts?

Assuming the language is supported, there should be no problem.

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 7, 2020

Who could submit PR for dependabot check?

@RDIL
Copy link
Contributor

RDIL commented Dec 7, 2020

What language is .props @xtqqczze ?

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 7, 2020

What language is .props @xtqqczze ?

MSBuild

@RDIL
Copy link
Contributor

RDIL commented Dec 7, 2020

What language is .props @xtqqczze ?

MSBuild

I'll check if dependabot supports it.

xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request Dec 8, 2020
@xtqqczze
Upgrade StyleCopAnalyzers to v1.2.0-beta.312
864aee5 
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.312

Supercedes PowerShell#14333.

Follow-up to PowerShell#14293.
@xtqqczze xtqqczze mentioned this pull request Dec 8, 2020
Merged
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 8, 2020

Closed in favour of #14354.

@xtqqczze xtqqczze closed this Dec 8, 2020
@xtqqczze xtqqczze deleted the StyleCop-v1.2.0-beta.304 branch December 9, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @iSazonov @RDIL @adityapatwardhan