-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update markdown test tools #14325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update markdown test tools #14325
Conversation
HTTP 429 -> Too many requests Related upstream issue: tcort/markdown-link-check#101 |
|
|
It seems markdown-link-check is making a HTTP GET request for every URL. This is not ideal behaviour for large binaries, to say the least: Lines 65 to 112 in ea3036d
|
|
@RDIL Please update markdown-link-check to v3.8.4. |
|
PowerShell-CI-static-analysis still has HTTP error 429 -> Too many requests |
We need update markdown-link-check config or commandline with
|
|
Documentation should be updated as well: PowerShell/.github/CONTRIBUTING.md Lines 91 to 102 in bb78d4b
|
|
@PoshChan please rerun linux |
|
@RDIL, you are not authorized to request a rebuild |
|
Fine, I'll do it myself. |
|
PowerShell-CI-static-analysis (Markdown and Common Tests): Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/learning-powershell/powershell-beginners-guide.md.https://www.computerperformance.co.uk/powershell/index.htm should work Connection timed out |
Look like a transient failure, but I've submitted #14431 to update the 301 redirect.
|
I'll rebase once that gets merged.
|
@RDIL No need wait for that PR, failures in PowerShell-CI-static-analysis have not persisted. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
|
Whoops, that wasn't supposed to happen - sorry for anybody that got pinged due to my rebase, it usually doesn't do that! |
|
🎉 Handy links: |
Signed-off-by: Reece Dunham me@rdil.rocks
PR Summary
PR Context
Staying somewhat up-to-date
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.