-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Remove dead code from SemanticVersion class #14320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@daxian-dbw @rjmholt Could you please explain how the Update: looks like a tricky bug in .Net Runtime. :-( |
|
@iSazonov This code path shouldn't be removed. It's the reason why you see the following from a |
|
Besides, this particular impact won't affect stable versions, because |
|
@daxian-dbw Thanks for clarify! |
I see your point but:
|
PR Summary
Remove dead code from SemanticVersion class. It was added pending the development of semantic version story but we got no feedback and no progress. Currently we are waiting .Net for the story.
The PR speeds up startup scenario on my laptop up to 50 ms.
PR Context
Related #14268
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.