Skip to content

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Dec 1, 2020

PR Summary

Use StringComparison.Ordinal instead of default StringComparison.CurrentCulture.

This looks like a bug but discovered in startup scenario perf analyze - perf win 0.7% (5 ms - so long because of ICU initialization).

PR Context

Related #14268

PR Checklist

@iSazonov iSazonov added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Dec 1, 2020
@iSazonov iSazonov requested a review from SteveL-MSFT December 1, 2020 06:05
@iSazonov iSazonov closed this Dec 2, 2020
@iSazonov iSazonov reopened this Dec 2, 2020
@iSazonov
Copy link
Collaborator Author

iSazonov commented Dec 2, 2020

Reopen to restart CIs.

@daxian-dbw daxian-dbw merged commit 548e939 into PowerShell:master Dec 2, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 3, 2020
@iSazonov iSazonov deleted the perf-startwith branch December 3, 2020 02:58
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants