-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Forwarding progress stream changes from Foreach-Object -Parallel runspaces #14271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@powercode Please add some example scripts/screenshot. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
A few days had passed , the fix still on its way ? |
test/powershell/Modules/Microsoft.PowerShell.Utility/Foreach-Object-Parallel.Tests.ps1
Outdated
Show resolved
Hide resolved
PaulHigin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @powercode Thanks for adding this!
…bject-Parallel.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
|
what action need to take for the 1 "expected checks" ? |
|
@powercode could you help to compile latest Powershell code but with your fix for windows x64 ? I want to use this feature before official release . I am not a code man , I don't know how to compile it. thanks ! |
|
@tlsalex You can download build.zip from CIs. |
|
/rebase |
|
🎉 Handy links: |
|
🎉 Handy links: |
PR Summary
Forwarding progress stream changes from
Foreach-Object -Parallelrunspaces in the same way as the other streams.#14254
PR Context
Now looks like this.
That it doesn't render perfectly is a separate issue.
The test looks different as the Progress stream is not forwardable. So the API is used instead.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.