Use AsSpan/AsMemory slice constructor #14265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtqqczze
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
ghost
assigned
Contributor
Author
|
@iSazonov Should we label the arguments, i.e. |
iSazonov
approved these changes
Nov 25, 2020
iSazonov
added
the
CL-CodeCleanup
Collaborator
I think we can skip this as obvious. |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #13500.
AsSpan().Slice(start, length)->AsSpan(start, length)Micro-benchmarks show decrease in code size and ~1.6x speedup.