Skip to content

Remove unnecessary finalizers #14248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 1 commit into from
Nov 24, 2020
Merged

Remove unnecessary finalizers #14248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/ContentCommandBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,14 +705,6 @@ public void Dispose()
GC.SuppressFinalize(this);
}

/// <summary>
/// Finalizer.
/// </summary>
~ContentCommandBase()
{
Dispose(false);
}
#endregion IDisposable

}
}
8 changes: 0 additions & 8 deletions ...Shell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutGridViewCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,13 +492,5 @@ public void Dispose()
this.Dispose(true);
GC.SuppressFinalize(this);
}

/// <summary>
/// Finalizer.
/// </summary>
~OutGridViewCommand()
{
Dispose(false);
}
}
}
8 changes: 0 additions & 8 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,6 @@ public class ShowCommandCommand : PSCmdlet, IDisposable
private object _commandViewModelObj;
#endregion

/// <summary>
/// Finalizes an instance of the ShowCommandCommand class.
/// </summary>
~ShowCommandCommand()
{
this.Dispose(false);
}

#region Input Cmdlet Parameter
/// <summary>
/// Gets or sets the command name.
Expand Down
8 changes: 0 additions & 8 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,6 @@ public void Dispose()
GC.SuppressFinalize(this);
}

/// <summary>
/// Finalizer.
/// </summary>
~TeeObjectCommand()
{
Dispose(false);
}

#region private
private CommandWrapper _commandWrapper;
private bool _alreadyDisposed;
Expand Down
8 changes: 0 additions & 8 deletions src/System.Management.Automation/engine/CommandProcessorBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,14 +957,6 @@ private void Dispose(bool disposing)
_disposed = true;
}

/// <summary>
/// Finalizer for class CommandProcessorBase.
/// </summary>
~CommandProcessorBase()
{
Dispose(false);
}

#endregion IDispose
}
}
8 changes: 0 additions & 8 deletions src/System.Management.Automation/engine/EventManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,14 +1510,6 @@ protected virtual void OnForwardEvent(PSEventArgs e)
ForwardEvent?.Invoke(this, e);
}

/// <summary>
/// Destructor for the EventManager class.
/// </summary>
~PSLocalEventManager()
{
Dispose(false);
}

/// <summary>
/// Disposes the EventManager class.
/// </summary>
Expand Down
8 changes: 0 additions & 8 deletions src/System.Management.Automation/engine/lang/scriptblock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,14 +1313,6 @@ private void Dispose(bool disposing)
_disposed = true;
}

/// <summary>
/// Finalizer for class SteppablePipeline.
/// </summary>
~SteppablePipeline()
{
Dispose(false);
}

#endregion IDispose
}

Expand Down
8 changes: 0 additions & 8 deletions src/System.Management.Automation/engine/pipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,6 @@ private void Dispose(bool disposing)
_disposed = true;
}

/// <summary>
/// Finalizer for class PipelineProcessor.
/// </summary>
~PipelineProcessor()
{
Dispose(false);
}

#endregion IDispose

#region Execution Logging
Expand Down