Skip to content

Enable SA1008: Opening parenthesis should be spaced correctly #14242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 6 commits into from
Apr 16, 2021
Merged

Enable SA1008: Opening parenthesis should be spaced correctly #14242

adityapatwardhan merged 6 commits into from
Apr 16, 2021

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Nov 23, 2020

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 26, 2020
@ghost ghost added the Stale label Dec 11, 2020
@ghost
Copy link

ghost commented Dec 11, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@xtqqczze xtqqczze mentioned this pull request Dec 11, 2020
Merged
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Dec 11, 2020
@xtqqczze xtqqczze closed this Dec 11, 2020
@xtqqczze xtqqczze reopened this Dec 11, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 11, 2020

Depends on #14398 (e7a1320).

@xtqqczze xtqqczze closed this Dec 12, 2020
@xtqqczze xtqqczze reopened this Dec 12, 2020
@xtqqczze xtqqczze closed this Dec 13, 2020
@xtqqczze xtqqczze reopened this Dec 13, 2020
@SteveL-MSFT SteveL-MSFT added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 15, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 17, 2020 01:48
@xtqqczze xtqqczze mentioned this pull request Dec 20, 2020
Closed
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 20, 2020

Depends on #14468.

@ghost ghost added the Review - Needed The PR is being reviewed label Dec 28, 2020
@ghost
Copy link

ghost commented Dec 28, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan adityapatwardhan merged commit a562fa6 into PowerShell:master Apr 16, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 16, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.6 milestone Apr 16, 2021
@xtqqczze xtqqczze deleted the SA1008 branch April 17, 2021 13:39
rkeithhill pushed a commit to rkeithhill/PowerShell that referenced this pull request May 3, 2021
@xtqqczze @rkeithhill
Enable SA1008 Opening parenthesis should be spaced correctly (Power…
ef6bf0f 
…Shell#14242)
@ghost
Copy link

ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze xtqqczze mentioned this pull request Oct 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.6

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @adityapatwardhan @SteveL-MSFT