Skip to content

Enable SA1504: All accessors should be single-line or multi-line #14241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Jan 9, 2021
Merged

Enable SA1504: All accessors should be single-line or multi-line #14241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,7 @@ dotnet_diagnostic.SA1502.severity = none
dotnet_diagnostic.SA1503.severity = none

# SA1504: All accessors should be single-line or multi-line
dotnet_diagnostic.SA1504.severity = none
dotnet_diagnostic.SA1504.severity = warning

# SA1505: Opening braces should not be followed by blank line
dotnet_diagnostic.SA1505.severity = none
Expand Down
20 changes: 16 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimAssociatedInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ public GetCimAssociatedInstanceCommand()
[Alias(CimBaseCommand.AliasCimInstance)]
public CimInstance InputObject
{
get { return CimInstance; }
get
{
return CimInstance;
}

set
{
Expand Down Expand Up @@ -118,7 +121,10 @@ public CimInstance InputObject
[Parameter]
public Uri ResourceUri
{
get { return resourceUri; }
get
{
return resourceUri;
}

set
{
Expand Down Expand Up @@ -146,7 +152,10 @@ public Uri ResourceUri
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public string[] ComputerName
{
get { return computerName; }
get
{
return computerName;
}

set
{
Expand All @@ -168,7 +177,10 @@ public string[] ComputerName
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public Microsoft.Management.Infrastructure.CimSession[] CimSession
{
get { return cimSession; }
get
{
return cimSession;
}

set
{
Expand Down
10 changes: 8 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimClassCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,10 @@ public GetCimClassCommand()
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public CimSession[] CimSession
{
get { return cimSession; }
get
{
return cimSession;
}

set
{
Expand All @@ -118,7 +121,10 @@ public CimSession[] CimSession
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public string[] ComputerName
{
get { return computerName; }
get
{
return computerName;
}

set
{
Expand Down
60 changes: 48 additions & 12 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ public GetCimInstanceCommand()
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public CimSession[] CimSession
{
get { return cimSession; }
get
{
return cimSession;
}

set
{
Expand All @@ -90,7 +93,10 @@ public CimSession[] CimSession
ParameterSetName = CimBaseCommand.ClassNameComputerSet)]
public string ClassName
{
get { return className; }
get
{
return className;
}

set
{
Expand Down Expand Up @@ -125,7 +131,10 @@ public string ClassName
ParameterSetName = CimBaseCommand.QuerySessionSet)]
public Uri ResourceUri
{
get { return resourceUri; }
get
{
return resourceUri;
}

set
{
Expand Down Expand Up @@ -161,7 +170,10 @@ public Uri ResourceUri
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public string[] ComputerName
{
get { return computerName; }
get
{
return computerName;
}

set
{
Expand All @@ -185,7 +197,10 @@ public string[] ComputerName
[Parameter(ParameterSetName = CimBaseCommand.ResourceUriSessionSet)]
public SwitchParameter KeyOnly
{
get { return keyOnly; }
get
{
return keyOnly;
}

set
{
Expand Down Expand Up @@ -220,7 +235,10 @@ public SwitchParameter KeyOnly
ParameterSetName = CimBaseCommand.QuerySessionSet)]
public string Namespace
{
get { return nameSpace; }
get
{
return nameSpace;
}

set
{
Expand Down Expand Up @@ -270,7 +288,10 @@ public string Namespace
[Alias(CimBaseCommand.AliasCimInstance)]
public CimInstance InputObject
{
get { return CimInstance; }
get
{
return CimInstance;
}

set
{
Expand All @@ -297,7 +318,10 @@ public CimInstance InputObject
ParameterSetName = CimBaseCommand.QuerySessionSet)]
public string Query
{
get { return query; }
get
{
return query;
}

set
{
Expand Down Expand Up @@ -326,7 +350,10 @@ public string Query

public string QueryDialect
{
get { return queryDialect; }
get
{
return queryDialect;
}

set
{
Expand Down Expand Up @@ -354,7 +381,10 @@ public string QueryDialect
[Parameter(ParameterSetName = CimBaseCommand.QuerySessionSet)]
public SwitchParameter Shallow
{
get { return shallow; }
get
{
return shallow;
}

set
{
Expand All @@ -381,7 +411,10 @@ public SwitchParameter Shallow
ParameterSetName = CimBaseCommand.ResourceUriComputerSet)]
public string Filter
{
get { return filter; }
get
{
return filter;
}

set
{
Expand Down Expand Up @@ -410,7 +443,10 @@ public string Filter
[Alias("SelectProperties")]
public string[] Property
{
get { return SelectProperties; }
get
{
return SelectProperties;
}

set
{
Expand Down
20 changes: 16 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimSessionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ public GetCimSessionCommand()
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public string[] ComputerName
{
get { return computername; }
get
{
return computername;
}

set
{
Expand All @@ -80,7 +83,10 @@ public string[] ComputerName
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public UInt32[] Id
{
get { return id; }
get
{
return id;
}

set
{
Expand All @@ -101,7 +107,10 @@ public UInt32[] Id
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public Guid[] InstanceId
{
get { return instanceid; }
get
{
return instanceid;
}

set
{
Expand All @@ -123,7 +132,10 @@ public Guid[] InstanceId
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public string[] Name
{
get { return name; }
get
{
return name;
}

set
{
Expand Down
50 changes: 40 additions & 10 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/InvokeCimMethodCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ public InvokeCimMethodCommand()
[Alias("Class")]
public string ClassName
{
get { return className; }
get
{
return className;
}

set
{
Expand Down Expand Up @@ -83,7 +86,10 @@ public string ClassName
ParameterSetName = CimBaseCommand.ResourceUriSessionSet)]
public Uri ResourceUri
{
get { return resourceUri; }
get
{
return resourceUri;
}

set
{
Expand All @@ -108,7 +114,10 @@ public Uri ResourceUri
ParameterSetName = CimClassSessionSet)]
public CimClass CimClass
{
get { return cimClass; }
get
{
return cimClass;
}

set
{
Expand All @@ -131,7 +140,10 @@ public CimClass CimClass
ParameterSetName = CimBaseCommand.QuerySessionSet)]
public string Query
{
get { return query; }
get
{
return query;
}

set
{
Expand All @@ -155,7 +167,10 @@ public string Query
ParameterSetName = CimBaseCommand.QuerySessionSet)]
public string QueryDialect
{
get { return queryDialect; }
get
{
return queryDialect;
}

set
{
Expand All @@ -182,7 +197,10 @@ public string QueryDialect
[Alias(CimBaseCommand.AliasCimInstance)]
public CimInstance InputObject
{
get { return CimInstance; }
get
{
return CimInstance;
}

set
{
Expand Down Expand Up @@ -224,7 +242,10 @@ public CimInstance InputObject
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public string[] ComputerName
{
get { return computerName; }
get
{
return computerName;
}

set
{
Expand Down Expand Up @@ -264,7 +285,10 @@ public string[] ComputerName
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
public CimSession[] CimSession
{
get { return cimSession; }
get
{
return cimSession;
}

set
{
Expand Down Expand Up @@ -294,7 +318,10 @@ public CimSession[] CimSession
[Alias("Name")]
public string MethodName
{
get { return methodName; }
get
{
return methodName;
}

set
{
Expand Down Expand Up @@ -325,7 +352,10 @@ public string MethodName
ParameterSetName = CimBaseCommand.ResourceUriSessionSet)]
public string Namespace
{
get { return nameSpace; }
get
{
return nameSpace;
}

set
{
Expand Down
Loading