Skip to content

Enable SA1504: All accessors should be single-line or multi-line #14241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Jan 9, 2021
Merged

Enable SA1504: All accessors should be single-line or multi-line #14241

iSazonov merged 1 commit into from
Jan 9, 2021

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Nov 23, 2020

@ghost ghost assigned daxian-dbw Nov 23, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 23, 2020

Depends on #14243.

@xtqqczze xtqqczze changed the title Enable SA1504: All accessors should be single-line or multi-line WIP: Enable SA1504: All accessors should be single-line or multi-line Nov 23, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 27, 2020
@xtqqczze xtqqczze changed the title WIP: Enable SA1504: All accessors should be single-line or multi-line Enable SA1504: All accessors should be single-line or multi-line Dec 11, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2020
@xtqqczze xtqqczze closed this Dec 12, 2020
@xtqqczze xtqqczze reopened this Dec 12, 2020
@xtqqczze xtqqczze closed this Dec 13, 2020
@xtqqczze xtqqczze reopened this Dec 13, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 13, 2020 12:35
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 13, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 23, 2020
@ghost
Copy link

ghost commented Dec 23, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Jan 9, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov iSazonov merged commit b7a431a into PowerShell:master Jan 9, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 9, 2021
@xtqqczze xtqqczze deleted the SA1504 branch January 18, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @daxian-dbw