Skip to content

Fix SA1642 for Microsoft.Management.Infrastructure.CimCmdlets #14239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Nov 27, 2020
Merged

Fix SA1642 for Microsoft.Management.Infrastructure.CimCmdlets #14239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4003bb3
Fix SA1642
xtqqczze Nov 23, 2020
43db132
Update summary text
xtqqczze Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/CimAsyncOperation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ internal abstract class CimAsyncOperation : IDisposable
#region Constructor

/// <summary>
/// The constructor.
/// Initializes a new instance of the <see cref="CimAsyncOperation"/> class.
/// </summary>
protected CimAsyncOperation()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimBaseAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace Microsoft.Management.Infrastructure.CimCmdlets
internal abstract class CimBaseAction
{
/// <summary>
/// Constructor method.
/// Initializes a new instance of the <see cref="CimBaseAction"/> class.
/// </summary>
protected CimBaseAction()
{
Expand Down Expand Up @@ -69,7 +69,7 @@ protected XOperationContextBase Context
internal class CimSyncAction : CimBaseAction, IDisposable
{
/// <summary>
/// The constructor.
/// Initializes a new instance of the <see cref="CimSyncAction"/> class.
/// </summary>
public CimSyncAction()
{
Expand Down
14 changes: 7 additions & 7 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimCommandBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace Microsoft.Management.Infrastructure.CimCmdlets
internal class ParameterDefinitionEntry
{
/// <summary>
/// Constructor.
/// Initializes a new instance of the <see cref="ParameterDefinitionEntry"/> class.
/// </summary>
/// <param name="parameterSetName"></param>
/// <param name="mandatory"></param>
Expand Down Expand Up @@ -70,7 +70,7 @@ internal bool IsMandatory
internal class ParameterSetEntry
{
/// <summary>
/// Constructor.
/// Initializes a new instance of the <see cref="ParameterSetEntry"/> class.
/// </summary>
/// <param name="mandatoryParameterCount"></param>
internal ParameterSetEntry(UInt32 mandatoryParameterCount)
Expand All @@ -81,7 +81,7 @@ internal ParameterSetEntry(UInt32 mandatoryParameterCount)
}

/// <summary>
/// Constructor.
/// Initializes a new instance of the <see cref="ParameterSetEntry"/> class.
/// </summary>
/// <param name="toClone"></param>
internal ParameterSetEntry(ParameterSetEntry toClone)
Expand All @@ -92,7 +92,7 @@ internal ParameterSetEntry(ParameterSetEntry toClone)
}

/// <summary>
/// Constructor.
/// Initializes a new instance of the <see cref="ParameterSetEntry"/> class.
/// </summary>
/// <param name="mandatoryParameterCount"></param>
/// <param name="mandatory"></param>
Expand Down Expand Up @@ -217,7 +217,7 @@ internal UInt32 SetMandatoryParameterCountAtBeginProcess
internal class ParameterBinder
{
/// <summary>
/// Constructor.
/// Initializes a new instance of the <see cref="ParameterBinder"/> class.
/// </summary>
/// <param name="parameters"></param>
/// <param name="sets"></param>
Expand Down Expand Up @@ -567,7 +567,7 @@ internal void SetParameter(object value, string parameterName)
#region constructors

/// <summary>
/// Constructor.
/// Initializes a new instance of the <see cref="CimBaseCommand"/> class.
/// </summary>
internal CimBaseCommand()
{
Expand All @@ -576,7 +576,7 @@ internal CimBaseCommand()
}

/// <summary>
/// Constructor.
/// Initializes a new instance of the <see cref="CimBaseCommand"/> class.
/// </summary>
internal CimBaseCommand(Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters,
Dictionary<string, ParameterSetEntry> sets)
Expand Down
4 changes: 1 addition & 3 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetAssociatedInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ namespace Microsoft.Management.Infrastructure.CimCmdlets
internal sealed class CimGetAssociatedInstance : CimAsyncOperation
{
/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimGetAssociatedInstance"/> class.
/// </summary>
public CimGetAssociatedInstance()
: base()
Expand Down
8 changes: 2 additions & 6 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetCimClass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ namespace Microsoft.Management.Infrastructure.CimCmdlets
internal class CimGetCimClassContext : XOperationContextBase
{
/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimGetCimClassContext"/> class.
/// </summary>
/// <param name="methodName"></param>
/// <param name="propertyName"></param>
Expand Down Expand Up @@ -104,9 +102,7 @@ internal string QualifierName
internal sealed class CimGetCimClass : CimAsyncOperation
{
/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimGetCimClass"/> class.
/// </summary>
public CimGetCimClass()
: base()
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public object Process(object resultObject)
internal class CimGetInstance : CimAsyncOperation
{
/// <summary>
/// Initializes a new instance of the <see cref="CimGetInstance"/> class.
/// <para>
/// Constructor
/// </para>
Expand Down
16 changes: 4 additions & 12 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimIndicationWatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,7 @@ public Exception Exception
private readonly Exception exception;

/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimIndicationEventExceptionEventArgs"/> class.
/// </summary>
/// <param name="result"></param>
public CimIndicationEventExceptionEventArgs(Exception theException)
Expand Down Expand Up @@ -108,9 +106,7 @@ public string Bookmark
}

/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimIndicationEventInstanceEventArgs"/> class.
/// </summary>
/// <param name="result"></param>
public CimIndicationEventInstanceEventArgs(CimSubscriptionResult result)
Expand Down Expand Up @@ -154,9 +150,7 @@ internal enum Status
public event EventHandler<CimIndicationEventArgs> CimIndicationArrived;

/// <summary>
/// <para>
/// Constructor with given computerName, namespace, queryExpression and timeout
/// </para>
/// Initializes a new instance of the <see cref="CimIndicationWatcher"/> class.
/// </summary>
/// <param name="computerName"></param>
/// <param name="nameSpace"></param>
Expand All @@ -176,9 +170,7 @@ public CimIndicationWatcher(
}

/// <summary>
/// <para>
/// Constructor with given cimsession, namespace, queryExpression and timeout
/// </para>
/// Initializes a new instance of the <see cref="CimIndicationWatcher"/> class.
/// </summary>
/// <param name="cimSession"></param>
/// <param name="nameSpace"></param>
Expand Down
8 changes: 2 additions & 6 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimInvokeCimMethod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ internal sealed class CimInvokeCimMethod : CimAsyncOperation
internal class CimInvokeCimMethodContext : XOperationContextBase
{
/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimInvokeCimMethodContext"/> class.
/// </summary>
/// <param name="theNamespace"></param>
/// <param name="theCollection"></param>
Expand Down Expand Up @@ -73,9 +71,7 @@ internal CimMethodParametersCollection ParametersCollection
}

/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimInvokeCimMethod"/> class.
/// </summary>
public CimInvokeCimMethod()
: base()
Expand Down
5 changes: 2 additions & 3 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimNewCimInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ namespace Microsoft.Management.Infrastructure.CimCmdlets
internal class CimNewCimInstanceContext : XOperationContextBase
{
/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimNewCimInstanceContext"/> class.
/// </summary>
/// <param name="methodName"></param>
/// <param name="propertyName"></param>
Expand All @@ -44,6 +42,7 @@ internal CimNewCimInstanceContext(
internal sealed class CimNewCimInstance : CimAsyncOperation
{
/// <summary>
/// Initializes a new instance of the <see cref="CimNewCimInstance"/> class.
/// <para>
/// Constructor
/// </para>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/CimPromptUser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace Microsoft.Management.Infrastructure.CimCmdlets
internal sealed class CimPromptUser : CimSyncAction
{
/// <summary>
/// Constructor.
/// Initializes a new instance of the <see cref="CimPromptUser"/> class.
/// </summary>
public CimPromptUser(string message,
CimPromptType prompt)
Expand Down
8 changes: 3 additions & 5 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimRegisterCimIndication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public CimSubscriptionResult Result
private readonly CimSubscriptionResult result;

/// <summary>
/// <para>Constructor</para>
/// Initializes a new instance of the <see cref="CimSubscriptionResultEventArgs"/> class.
/// </summary>
/// <param name="theResult"></param>
public CimSubscriptionResultEventArgs(
Expand Down Expand Up @@ -92,7 +92,7 @@ public Exception Exception
private readonly Exception exception;

/// <summary>
/// <para>Constructor</para>
/// Initializes a new instance of the <see cref="CimSubscriptionExceptionEventArgs"/> class.
/// </summary>
/// <param name="theResult"></param>
public CimSubscriptionExceptionEventArgs(
Expand All @@ -118,9 +118,7 @@ internal sealed class CimRegisterCimIndication : CimAsyncOperation
public event EventHandler<CimSubscriptionEventArgs> OnNewSubscriptionResult;

/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimRegisterCimIndication"/> class.
/// </summary>
public CimRegisterCimIndication()
: base()
Expand Down
8 changes: 2 additions & 6 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimRemoveCimInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ namespace Microsoft.Management.Infrastructure.CimCmdlets
internal class CimRemoveCimInstanceContext : XOperationContextBase
{
/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimRemoveCimInstanceContext"/> class.
/// </summary>
/// <param name="theNamespace"></param>
/// <param name="theProxy"></param>
Expand All @@ -39,9 +37,7 @@ internal CimRemoveCimInstanceContext(string theNamespace,
internal sealed class CimRemoveCimInstance : CimGetInstance
{
/// <summary>
/// <para>
/// Constructor
/// </para>
/// Initializes a new instance of the <see cref="CimRemoveCimInstance"/> class.
/// </summary>
public CimRemoveCimInstance()
: base()
Expand Down
Loading