Enable SA1643: Destructor summary documentation #14236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
xtqqczze
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
xtqqczze
commented
Nov 23, 2020
Contributor
Author
|
@iSazonov Maybe we can remove the finalizer on classes without unmanaged resources? |
iSazonov
approved these changes
Nov 23, 2020
iSazonov
added
the
CL-CodeCleanup
This was referenced Nov 23, 2020
Collaborator
|
@xtqqczze Please resolve merge conflicts. |
Contributor
Author
|
Depends on #14248. |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable SA1643: Destructor summary documentation should begin with standard text
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1643.md