Skip to content

Mark private members as static part 1 #14224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Nov 24, 2020
Merged

Mark private members as static part 1 #14224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetAssociatedInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public void GetCimAssociatedInstance(GetCimAssociatedInstanceCommand cmdlet)
/// </summary>
/// <param name="proxy"></param>
/// <param name="cmdlet"></param>
private void SetSessionProxyProperties(
private static void SetSessionProxyProperties(
ref CimSessionProxy proxy,
GetCimAssociatedInstanceCommand cmdlet)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetCimClass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public void GetCimClass(GetCimClassCommand cmdlet)
/// </summary>
/// <param name="proxy"></param>
/// <param name="cmdlet"></param>
private void SetSessionProxyProperties(
private static void SetSessionProxyProperties(
ref CimSessionProxy proxy,
GetCimClassCommand cmdlet)
{
Expand Down
10 changes: 5 additions & 5 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ protected void GetCimInstanceInternal(CimBaseCommand cmdlet)
CimSessionProxy proxy = CreateSessionProxy(computerName, targetCimInstance, cmdlet);
if (isGetCimInstanceCommand)
{
this.SetPreProcess(proxy, cmdlet as GetCimInstanceCommand);
SetPreProcess(proxy, cmdlet as GetCimInstanceCommand);
}

proxys.Add(proxy);
Expand All @@ -108,7 +108,7 @@ protected void GetCimInstanceInternal(CimBaseCommand cmdlet)
CimSessionProxy proxy = CreateSessionProxy(computerName, cmdlet);
if (isGetCimInstanceCommand)
{
this.SetPreProcess(proxy, cmdlet as GetCimInstanceCommand);
SetPreProcess(proxy, cmdlet as GetCimInstanceCommand);
}

proxys.Add(proxy);
Expand All @@ -124,7 +124,7 @@ protected void GetCimInstanceInternal(CimBaseCommand cmdlet)
CimSessionProxy proxy = CreateSessionProxy(session, cmdlet);
if (isGetCimInstanceCommand)
{
this.SetPreProcess(proxy, cmdlet as GetCimInstanceCommand);
SetPreProcess(proxy, cmdlet as GetCimInstanceCommand);
}

proxys.Add(proxy);
Expand Down Expand Up @@ -373,7 +373,7 @@ protected static CimInstance GetCimInstanceParameter(CimBaseCommand cmdlet)
/// </summary>
/// <param name="proxy"></param>
/// <param name="cmdlet"></param>
private void SetSessionProxyProperties(
private static void SetSessionProxyProperties(
ref CimSessionProxy proxy,
CimBaseCommand cmdlet)
{
Expand Down Expand Up @@ -514,7 +514,7 @@ protected CimSessionProxy CreateSessionProxy(
/// </summary>
/// <param name="proxy"></param>
/// <param name="cmdlet"></param>
private void SetPreProcess(CimSessionProxy proxy, GetCimInstanceCommand cmdlet)
private static void SetPreProcess(CimSessionProxy proxy, GetCimInstanceCommand cmdlet)
{
if (cmdlet.KeyOnly || (cmdlet.SelectProperties != null))
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/CimInvokeCimMethod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ public void InvokeCimMethodOnCimInstance(CimInstance cimInstance, XOperationCont
/// </summary>
/// <param name="proxy"></param>
/// <param name="cmdlet"></param>
private void SetSessionProxyProperties(
private static void SetSessionProxyProperties(
ref CimSessionProxy proxy,
InvokeCimMethodCommand cmdlet)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/CimNewCimInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ internal void GetCimInstance(CimInstance cimInstance, XOperationContextBase cont
/// </summary>
/// <param name="proxy"></param>
/// <param name="cmdlet"></param>
private void SetSessionProxyProperties(
private static void SetSessionProxyProperties(
ref CimSessionProxy proxy,
NewCimInstanceCommand cmdlet)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/CimSessionOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ private void RemoveSessionInternal(CimSession session, CimSessionWrapper wrapper
/// <param name="errRecords"></param>
/// <param name="propertyName"></param>
/// <param name="propertyValue"></param>
private void AddErrorRecord(
private static void AddErrorRecord(
ref List<ErrorRecord> errRecords,
string propertyName,
object propertyValue)
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/CimSessionProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ private static bool GetIsCliXmlTestabilityHookActive()
return !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("CDXML_CLIXML_TEST"));
}

private object PostProcessCimInstance(object resultObject)
private static object PostProcessCimInstance(object resultObject)
{
DebugHelper.WriteLogEx();
if (isCliXmlTestabilityHookActive && (resultObject is CimInstance))
Expand Down