Skip to content

Fix SA1119: Statement should not use unnecessary parenthesis part 1 #14204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Jan 9, 2021
Merged

Fix SA1119: Statement should not use unnecessary parenthesis part 1 #14204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ protected void GetCimInstanceInternal(CimBaseCommand cmdlet)
GetComputerName(cmdlet));
string nameSpace;
List<CimSessionProxy> proxys = new();
bool isGetCimInstanceCommand = (cmdlet is GetCimInstanceCommand);
bool isGetCimInstanceCommand = cmdlet is GetCimInstanceCommand;
CimInstance targetCimInstance = null;
switch (cmdlet.ParameterSetName)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimSessionOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ internal IEnumerable<PSObject> QuerySession(IEnumerable<string> nameArray,
if (pattern.IsMatch(kvp.Key))
{
HashSet<CimSessionWrapper> wrappers = kvp.Value;
foundSession = (wrappers.Count > 0);
foundSession = wrappers.Count > 0;
foreach (CimSessionWrapper wrapper in wrappers)
{
if (!sessionIds.Contains(wrapper.SessionId))
Expand Down Expand Up @@ -644,7 +644,7 @@ internal IEnumerable<PSObject> QuerySessionByComputerName(
if (this.curCimSessionsByComputerName.ContainsKey(computername))
{
HashSet<CimSessionWrapper> wrappers = this.curCimSessionsByComputerName[computername];
foundSession = (wrappers.Count > 0);
foundSession = wrappers.Count > 0;
foreach (CimSessionWrapper wrapper in wrappers)
{
if (!sessionIds.Contains(wrapper.SessionId))
Expand Down
10 changes: 5 additions & 5 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimSessionProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ public CimSessionProxy(CimSessionProxy proxy)
public CimSessionProxy(string computerName)
{
CreateSetSession(computerName, null, null, null, false);
this.isDefaultSession = (computerName == ConstValue.NullComputerName);
this.isDefaultSession = computerName == ConstValue.NullComputerName;
}

/// <summary>
Expand All @@ -360,7 +360,7 @@ public CimSessionProxy(string computerName)
public CimSessionProxy(string computerName, CimSessionOptions sessionOptions)
{
CreateSetSession(computerName, null, sessionOptions, null, false);
this.isDefaultSession = (computerName == ConstValue.NullComputerName);
this.isDefaultSession = computerName == ConstValue.NullComputerName;
}

/// <summary>
Expand Down Expand Up @@ -403,7 +403,7 @@ public CimSessionProxy(string computerName, CimInstance cimInstance)

string cimsessionComputerName = cimInstance.GetCimSessionComputerName();
CreateSetSession(cimsessionComputerName, null, null, null, false);
this.isDefaultSession = (cimsessionComputerName == ConstValue.NullComputerName);
this.isDefaultSession = cimsessionComputerName == ConstValue.NullComputerName;

DebugHelper.WriteLogEx("Create a temp session with computerName = {0}.", 0, cimsessionComputerName);
}
Expand All @@ -421,7 +421,7 @@ public CimSessionProxy(string computerName, CimInstance cimInstance)
public CimSessionProxy(string computerName, CimSessionOptions sessionOptions, CimOperationOptions operOptions)
{
CreateSetSession(computerName, null, sessionOptions, operOptions, false);
this.isDefaultSession = (computerName == ConstValue.NullComputerName);
this.isDefaultSession = computerName == ConstValue.NullComputerName;
}

/// <summary>
Expand All @@ -436,7 +436,7 @@ public CimSessionProxy(string computerName, CimSessionOptions sessionOptions, Ci
public CimSessionProxy(string computerName, CimOperationOptions operOptions)
{
CreateSetSession(computerName, null, null, operOptions, false);
this.isDefaultSession = (computerName == ConstValue.NullComputerName);
this.isDefaultSession = computerName == ConstValue.NullComputerName;
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimClassCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ protected override void EndProcessing()
/// </summary>
private CimGetCimClass GetOperationAgent()
{
return (this.AsyncOperation as CimGetCimClass);
return this.AsyncOperation as CimGetCimClass;
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ protected override void EndProcessing()
/// </summary>
private CimGetInstance GetOperationAgent()
{
return (this.AsyncOperation as CimGetInstance);
return this.AsyncOperation as CimGetInstance;
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/NewCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ protected override void EndProcessing()
/// </summary>
private CimNewCimInstance GetOperationAgent()
{
return (this.AsyncOperation as CimNewCimInstance);
return this.AsyncOperation as CimNewCimInstance;
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/NewCimSessionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ internal void BuildSessionOptions(out CimSessionOptions outputOptions, out CimCr
outputCredential = null;
if (options != null)
{
DComSessionOptions dcomOptions = (options as DComSessionOptions);
DComSessionOptions dcomOptions = options as DComSessionOptions;
if (dcomOptions != null)
{
bool conflict = false;
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/RemoveCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ protected override void EndProcessing()
/// </summary>
private CimRemoveCimInstance GetOperationAgent()
{
return (this.AsyncOperation as CimRemoveCimInstance);
return this.AsyncOperation as CimRemoveCimInstance;
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Management.Infrastructure.CimCmdlets/SetCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ protected override void EndProcessing()
/// </summary>
private CimSetCimInstance GetOperationAgent()
{
return (this.AsyncOperation as CimSetCimInstance);
return this.AsyncOperation as CimSetCimInstance;
}

/// <summary>
Expand Down