Skip to content

Fix SA1119: Statement should not use unnecessary parenthesis part 1 #14204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Jan 9, 2021
Merged

Fix SA1119: Statement should not use unnecessary parenthesis part 1 #14204

iSazonov merged 1 commit into from
Jan 9, 2021

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Nov 20, 2020 •
edited
Loading

src\Microsoft.Management.Infrastructure.CimCmdlets\

Contributes to "Enable SA1119: Statement should not use unnecessary parenthesis" (#14133).

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1119.md

@ghost ghost assigned TravisEz13 Nov 20, 2020
@xtqqczze xtqqczze mentioned this pull request Nov 20, 2020
Closed
@xtqqczze xtqqczze changed the title Fix SA1119 part 1 Fix SA1119 Statement should not use unnecessary parenthesis part 1 Nov 20, 2020
@xtqqczze xtqqczze changed the title Fix SA1119 Statement should not use unnecessary parenthesis part 1 Fix SA1119: Statement should not use unnecessary parenthesis part 1 Nov 20, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 20, 2020

Please split the PR on 3-4-5 PRs.

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost
Copy link

ghost commented Nov 28, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 30, 2020

Please split the PR on 3-4-5 PRs.

OK

@xtqqczze xtqqczze closed this Dec 8, 2020
@xtqqczze xtqqczze reopened this Dec 8, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 9, 2020
@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Jan 9, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov iSazonov merged commit bb55515 into PowerShell:master Jan 9, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @TravisEz13