Skip to content

Enable SA1002: Semicolons should be spaced correctly #14197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Nov 21, 2020
Merged

Enable SA1002: Semicolons should be spaced correctly #14197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,7 +1017,7 @@ dotnet_diagnostic.SA1000.severity = none
dotnet_diagnostic.SA1001.severity = none

# SA1002: Semicolons should be spaced correctly
dotnet_diagnostic.SA1002.severity = none
dotnet_diagnostic.SA1002.severity = warning

# SA1003: Symbols should be spaced correctly
dotnet_diagnostic.SA1003.severity = none
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2327,7 +2327,7 @@ private static byte[] ConvertEnvVarsToByteArray(StringDictionary sd)
StringBuilder builder = new StringBuilder();
for (int i = 0; i < sd.Count; i++)
{
builder.Append(array[i]);//
builder.Append(array[i]);
builder.Append('=');
builder.Append(strArray2[i]);
builder.Append('\0');
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.WSMan.Management/ConfigProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,7 @@ protected override void GetItem(string path)
}
}
}
catch (PSArgumentNullException) { return;/*Leaving this known exception for no value found. Not Throwing error.*/}
catch (PSArgumentNullException) { return; /*Leaving this known exception for no value found. Not Throwing error.*/}
catch (NullReferenceException) { return; /*Leaving this known exception for no value found. Not Throwing error.*/}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.WSMan.Management/WsManHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ internal string ProcessInput(IWSManEx wsman, string filepath, string operation,
}
else
{
XmlNode tmpNode = node.ChildNodes[0];//.Item[0];
XmlNode tmpNode = node.ChildNodes[0]; //.Item[0];
if (!tmpNode.NodeType.ToString().Equals("text", StringComparison.OrdinalIgnoreCase))
{
throw new ArgumentException(_resourceMgr.GetString("NOAttributeMatch"));
Expand Down
4 changes: 2 additions & 2 deletions src/System.Management.Automation/engine/hostifaces/History.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ internal HistoryInfo[] GetEntries(long id, long count, SwitchParameter newest)
}
else
{
index = _countEntriesAdded;//SmallestIDinBuffer
index = _countEntriesAdded; //SmallestIDinBuffer

for (long i = count - 1; i >= 0;)
{
Expand Down Expand Up @@ -1816,7 +1816,7 @@ private void ClearHistoryByID()
// confirmation message if all the clearhistory cmdlet is used without any parameters
if (!_countParameterSpecified)
{
string message = StringUtil.Format(HistoryStrings.ClearHistoryWarning, "Warning");// "The command would clear all the entry(s) from the session history,Are you sure you want to continue ?";
string message = StringUtil.Format(HistoryStrings.ClearHistoryWarning, "Warning"); // "The command would clear all the entry(s) from the session history,Are you sure you want to continue ?";
if (!ShouldProcess(message))
{
return;
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/interpreter/LightDelegateCreator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ internal void Compile(object state)
// So change the lambda's delegate type to Func<...> or
// Action<...> so it can be called from the LightLambda.Run
// methods.
LambdaExpression lambda = (_lambda as LambdaExpression);// ?? (LambdaExpression)((LightLambdaExpression)_lambda).Reduce();
LambdaExpression lambda = (_lambda as LambdaExpression); // ?? (LambdaExpression)((LightLambdaExpression)_lambda).Reduce();
if (_interpreter != null)
{
_compiledDelegateType = GetFuncOrAction(lambda);
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/client/RemoteRunspacePoolInternal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,7 +1882,7 @@ private void WaitAndRaiseConnectEventsProc(object state)
private readonly RunspaceConnectionInfo _connectionInfo; // connection info with which this
// runspace is created
// data structure handler handling
private RunspacePoolAsyncResult _openAsyncResult;// async result object generated on
private RunspacePoolAsyncResult _openAsyncResult; // async result object generated on
// CoreOpen
private RunspacePoolAsyncResult _closeAsyncResult; // async result object generated by
// BeginClose
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/remoting/server/serverremotesession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ internal void ExecuteConnect(byte[] connectData, out byte[] connectResponseData)
// as this is executed only when connecting from a new client that does not have any previous fragments context.
// no problem even if fragment Ids in this response and the sessiontransport stream clash (interfere) and its guaranteed
// that the fragments in connect response are always complete (enclose a complete object).
SerializedDataStream stream = new SerializedDataStream(4 * 1024);//Each message with fragment headers cannot cross 4k
SerializedDataStream stream = new SerializedDataStream(4 * 1024); //Each message with fragment headers cannot cross 4k
stream.Enter();
capability.Serialize(stream, fragmentor);
stream.Exit();
Expand Down
8 changes: 4 additions & 4 deletions test/tools/WebListener/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static IWebHost BuildWebHost(string[] args) =>
HttpsConnectionAdapterOptions httpsOption = new HttpsConnectionAdapterOptions();
httpsOption.SslProtocols = SslProtocols.Tls12;
httpsOption.ClientCertificateMode = ClientCertificateMode.AllowCertificate;
httpsOption.ClientCertificateValidation = (inCertificate, inChain, inPolicy) => {return true;};
httpsOption.ClientCertificateValidation = (inCertificate, inChain, inPolicy) => { return true; };
httpsOption.CheckCertificateRevocation = false;
httpsOption.ServerCertificate = certificate;
listenOptions.UseHttps(httpsOption);
Expand All @@ -53,7 +53,7 @@ public static IWebHost BuildWebHost(string[] args) =>
HttpsConnectionAdapterOptions httpsOption = new HttpsConnectionAdapterOptions();
httpsOption.SslProtocols = SslProtocols.Tls11;
httpsOption.ClientCertificateMode = ClientCertificateMode.AllowCertificate;
httpsOption.ClientCertificateValidation = (inCertificate, inChain, inPolicy) => {return true;};
httpsOption.ClientCertificateValidation = (inCertificate, inChain, inPolicy) => { return true; };
httpsOption.CheckCertificateRevocation = false;
httpsOption.ServerCertificate = certificate;
listenOptions.UseHttps(httpsOption);
Expand All @@ -64,7 +64,7 @@ public static IWebHost BuildWebHost(string[] args) =>
HttpsConnectionAdapterOptions httpsOption = new HttpsConnectionAdapterOptions();
httpsOption.SslProtocols = SslProtocols.Tls;
httpsOption.ClientCertificateMode = ClientCertificateMode.AllowCertificate;
httpsOption.ClientCertificateValidation = (inCertificate, inChain, inPolicy) => {return true;};
httpsOption.ClientCertificateValidation = (inCertificate, inChain, inPolicy) => { return true; };
httpsOption.CheckCertificateRevocation = false;
httpsOption.ServerCertificate = certificate;
listenOptions.UseHttps(httpsOption);
Expand All @@ -75,7 +75,7 @@ public static IWebHost BuildWebHost(string[] args) =>
HttpsConnectionAdapterOptions httpsOption = new HttpsConnectionAdapterOptions();
httpsOption.SslProtocols = SslProtocols.Tls13;
httpsOption.ClientCertificateMode = ClientCertificateMode.AllowCertificate;
httpsOption.ClientCertificateValidation = (inCertificate, inChain, inPolicy) => {return true;};
httpsOption.ClientCertificateValidation = (inCertificate, inChain, inPolicy) => { return true; };
httpsOption.CheckCertificateRevocation = false;
httpsOption.ServerCertificate = certificate;
listenOptions.UseHttps(httpsOption);
Expand Down