Skip to content

Enable nullable: System.Management.Automation.Language.ITypeName #14181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 4 commits into from
Apr 20, 2021
Merged

Enable nullable: System.Management.Automation.Language.ITypeName #14181

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8e7805
Enable nullable: System.Management.Automation.Language.ITypeName
powercode Nov 20, 2020
4b553a9
Removing whitespace before/after nullable pragma
powercode Nov 20, 2020
31ee343
Removing whitespace before/after nullable pragma
powercode Nov 20, 2020
808e39a
Correcting nullability for return values
powercode Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/System.Management.Automation/engine/parser/ast.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8110,6 +8110,7 @@ internal override object Accept(ICustomAstVisitor visitor)
/// <summary>
/// The name and attributes of a type.
/// </summary>
#nullable enable
public interface ITypeName
{
/// <summary>
Expand All @@ -8125,7 +8126,7 @@ public interface ITypeName
/// <summary>
/// The name of the assembly, if specified, otherwise null.
/// </summary>
string AssemblyName { get; }
string? AssemblyName { get; }

/// <summary>
/// Returns true if the type names an array, false otherwise.
Expand All @@ -8140,20 +8141,21 @@ public interface ITypeName
/// <summary>
/// Returns the <see cref="System.Type"/> that this typename represents, if such a type exists, null otherwise.
/// </summary>
Type GetReflectionType();
Type? GetReflectionType();

/// <summary>
/// Assuming the typename is an attribute, returns the <see cref="System.Type"/> that this typename represents.
/// By convention, the typename may omit the suffix "Attribute". Lookup will attempt to resolve the type as is,
/// and if that fails, the suffix "Attribute" will be appended.
/// </summary>
Type GetReflectionAttributeType();
Type? GetReflectionAttributeType();

/// <summary>
/// The extent of the typename.
/// </summary>
IScriptExtent Extent { get; }
}
#nullable restore

internal interface ISupportsTypeCaching
{
Expand Down