-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Enable nullable: System.Management.Automation.Language.ITypeName #14181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nullable: System.Management.Automation.Language.ITypeName #14181
Conversation
iSazonov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please
- move directives in right place
string AssemblyName { get; }- comment says it can be null.- add XML comments to non-nullable members like "This never returns null."
|
I think we shall have a discussion before specifying nullness in the documentation. That doesn't seem to be something that is done anywhere else, and is should anyways be automatically generated based on the type. |
Currently (and unlikely to change in the near future) if there is no "?" then the reader cannot understand whether the type is annotated or not. It is in these cases that I suggest adding the standard comment. |
|
Sure, but the vast majority of these types are internal, and the situation is no worst than it has been before. On the flip side, it puts an extra burden on us working with this, lowering the chance of having it done at all. |
|
The work is certainly huge and at some point we will no longer remember the details of the work already done - comments will help us. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
LGTM, matches what I committed in 46fc9c97cc4b72c8b35ddb8056c2c17b2e242247 before I rebased to focus on a single interface. |
|
@iSazonov can you update your review? |
Tracking issue: #12631.