Skip to content

Enable nullable: System.Management.Automation.Host.IHostUISupportsMultipleChoiceSelection #14172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
Jan 9, 2021
Merged

Enable nullable: System.Management.Automation.Host.IHostUISupportsMultipleChoiceSelection #14172

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a4b6b4
Enable nullable: System.Management.Automation.Host.IHostUISupportsMul…
powercode Nov 19, 2020
8c916ad
Removing whitespace before/after nullable pragma
powercode Nov 20, 2020
a08f3ae
Removing whitespace before/after nullable pragma
powercode Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/System.Management.Automation/engine/hostifaces/MshHostUserInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,6 +1201,7 @@ public void Dispose()
/// by giving the user ability to select more than one choice. The PromptForChoice method available
/// in PSHostUserInterface class supports only one choice selection.
/// </summary>
#nullable enable
public interface IHostUISupportsMultipleChoiceSelection
{
/// <summary>
Expand All @@ -1225,9 +1226,10 @@ public interface IHostUISupportsMultipleChoiceSelection
/// implementation.
/// </returns>
/// <seealso cref="System.Management.Automation.Host.PSHostUserInterface.PromptForChoice"/>
Collection<int> PromptForChoice(string caption, string message,
Collection<ChoiceDescription> choices, IEnumerable<int> defaultChoices);
Collection<int> PromptForChoice(string? caption, string? message,
Copy link
Collaborator

@iSazonov iSazonov Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in XML comment - implementations should never return null.

Copy link
Collaborator Author

@powercode powercode Nov 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a compiler warning - I don't see the point of stating the obvious.

Collection<ChoiceDescription> choices, IEnumerable<int>? defaultChoices);
}
#nullable restore

/// <summary>
/// Helper methods used by PowerShell's Hosts: ConsoleHost and InternalHost to process
Expand Down