Skip to content

Enable nullable: System.Management.Automation.Language.IAstPostVisitHandler #14164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjmholt merged 4 commits into from
Dec 9, 2020
Merged

Enable nullable: System.Management.Automation.Language.IAstPostVisitHandler #14164

rjmholt merged 4 commits into from
Dec 9, 2020

Conversation

@powercode
Copy link
Collaborator

@powercode powercode commented Nov 19, 2020

Tracking issue: #12631.

@ghost ghost assigned rjmholt Nov 19, 2020
@rjmholt
Copy link
Collaborator

rjmholt commented Nov 20, 2020

@PoshChan please remind me in 1 day

@PoshChan
Copy link
Collaborator

PoshChan commented Nov 21, 2020

@rjmholt, this is the reminder you requested 1 day ago

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost
Copy link

ghost commented Nov 28, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt
Copy link
Collaborator

rjmholt commented Dec 9, 2020

@powercode looks like the build is failing due to changes in this PR:

/home/vsts/work/1/s/src/System.Management.Automation/engine/parser/PreOrderVisitor.cs(252,1): error SA1507: Code should not contain multiple blank lines in a row [/home/vsts/work/1/s/src/System.Management.Automation/System.Management.Automation.csproj]

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 9, 2020
rjmholt
rjmholt reviewed Dec 9, 2020
View reviewed changes
@rjmholt
Copy link
Collaborator

rjmholt commented Dec 9, 2020

@PoshChan please remind me in 1 hour

@rjmholt rjmholt merged commit 9724293 into PowerShell:master Dec 9, 2020
@PoshChan
Copy link
Collaborator

PoshChan commented Dec 9, 2020

@rjmholt, this is the reminder you requested 1 hour ago

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 11, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@powercode powercode deleted the nullable/IAstPostVisitHandler branch December 16, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

4 participants

@powercode @rjmholt @PoshChan @iSazonov