Skip to content

Restrict New-Object in NoLanguage mode under lock down #14139 #14140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjmholt merged 15 commits into from
Dec 8, 2020
Merged

Restrict New-Object in NoLanguage mode under lock down #14139 #14140

rjmholt merged 15 commits into from
Dec 8, 2020

Conversation

@krishnayalavarthi
Copy link
Contributor

@krishnayalavarthi krishnayalavarthi commented Nov 19, 2020 •
edited by SteveL-MSFT
Loading

PR Summary

Restrict New-Object in NoLanguage mode under lock down #14139

PR Context

PR Checklist

@ghost ghost assigned rjmholt Nov 19, 2020
@SteveL-MSFT SteveL-MSFT changed the title Possible exploitation of New-Object in NoLanguage mode #14139 Restrict New-Object in NoLanguage mode under lock down #14139 Nov 19, 2020
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 21, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 2, 2020
@ghost
Copy link

ghost commented Dec 2, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@krishnayalavarthi
Copy link
Contributor Author

krishnayalavarthi commented Dec 2, 2020

image

The test case passed on my local machine where as it failed in the CI.

Krishna Yalavarthi added 2 commits December 1, 2020 18:59
rjmholt
rjmholt reviewed Dec 3, 2020
View reviewed changes
@rjmholt
Copy link
Collaborator

rjmholt commented Dec 3, 2020

The test case passed on my local machine where as it failed in the CI.

The screenshot you've showed there isn't CI failing or passing. Those tests are being skipped. I'm guessing it's a non-Windows CI machine?

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 3, 2020
PaulHigin
PaulHigin approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit b007952 into PowerShell:master Dec 8, 2020
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@sdwheeler sdwheeler mentioned this pull request Jan 25, 2021
Closed
@PaulHigin PaulHigin mentioned this pull request Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

2 more reviewers

@rjmholt rjmholt rjmholt approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krishnayalavarthi @rjmholt @PaulHigin @iSazonov