Skip to content

Enable SA1507: Code should not contain multiple blank lines in a row #14136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Nov 20, 2020
Merged

Enable SA1507: Code should not contain multiple blank lines in a row #14136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32d54c0
Enable SA1507: Code should not contain multiple blank lines in a row
xtqqczze Nov 18, 2020
c978b05
Fix SA1507
xtqqczze Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,7 +1373,7 @@ dotnet_diagnostic.SA1505.severity = none
dotnet_diagnostic.SA1506.severity = none

# SA1507: Code should not contain multiple blank lines in a row
dotnet_diagnostic.SA1507.severity = none
dotnet_diagnostic.SA1507.severity = warning

# SA1508: Closing braces should not be preceded by blank line
dotnet_diagnostic.SA1508.severity = none
Expand Down
1 change: 0 additions & 1 deletion src/System.Management.Automation/engine/TypeTable_Types_Ps1Xml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9227,7 +9227,6 @@ private void Process_Types_Ps1Xml(string filePath, ConcurrentBag<string> errors)
#if UNIX
#region UnixStat


if (ExperimentalFeature.IsEnabled("PSUnixFileStat"))
{
typeName = @"System.IO.FileSystemInfo";
Expand Down
1 change: 0 additions & 1 deletion src/powershell/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ private static void AttemptExecPwshLogin(string[] args)
// We can reuse this value later to prevent needing to call a .NET API
// to generate our exec invocation.


// We don't care about argc's value, since argv[0] must always exist.
// Skip over argc, but remember where exec_path is for later
executablePathPtr = IntPtr.Add(procargs, sizeof(int));
Expand Down
1 change: 0 additions & 1 deletion test/tools/WebListener/Controllers/DosController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public string Index()

Response.StatusCode = 200;


StringValues dosType;
if (Request.Query.TryGetValue("dosType", out dosType))
{
Expand Down