Skip to content

Enable CA1065: Do not raise exceptions in unexpected locations #14117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 1 commit into from
Nov 19, 2020
Merged

Enable CA1065: Do not raise exceptions in unexpected locations #14117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ dotnet_diagnostic.CA1063.severity = none
dotnet_diagnostic.CA1064.severity = none

# CA1065: Do not raise exceptions in unexpected locations
dotnet_diagnostic.CA1065.severity = none
dotnet_diagnostic.CA1065.severity = warning

# CA1066: Implement IEquatable when overriding Object.Equals
dotnet_diagnostic.CA1066.severity = none
Expand Down
1 change: 1 addition & 0 deletions src/System.Management.Automation/engine/Attributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,6 +1618,7 @@ public sealed class ValidateSetAttribute : ValidateEnumeratedArgumentsAttribute
/// <summary>
/// Gets the valid values in the set.
/// </summary>
[SuppressMessage("Design", "CA1065:Do not raise exceptions in unexpected locations", Justification = "<Pending>")]
public IList<string> ValidValues
{
get
Expand Down
4 changes: 4 additions & 0 deletions src/System.Management.Automation/engine/MshMemberInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Collections.ObjectModel;
using System.Collections.Specialized;
using System.ComponentModel;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.Linq;
using System.Management.Automation.Internal;
Expand Down Expand Up @@ -875,6 +876,7 @@ public override PSMemberInfo Copy()
/// </summary>
/// <exception cref="GetValueException">When getting and there is no getter or when the getter throws an exception.</exception>
/// <exception cref="SetValueException">When setting and there is no setter or when the setter throws an exception.</exception>
[SuppressMessage("Design", "CA1065:Do not raise exceptions in unexpected locations", Justification = "<Pending>")]
public override object Value
{
get
Expand Down Expand Up @@ -964,6 +966,7 @@ public override object Value
/// Gets the type of the value for this member.
/// </summary>
/// <exception cref="GetValueException">If there is no property getter.</exception>
[SuppressMessage("Design", "CA1065:Do not raise exceptions in unexpected locations", Justification = "<Pending>")]
public override string TypeNameOfValue
{
get
Expand Down Expand Up @@ -1786,6 +1789,7 @@ public override PSMemberInfo Copy()
/// </exception>
/// <exception cref="SetValueException">When setting and there is no setter,
/// when the setter throws an exception or when there is no Runspace to run the script.</exception>
[SuppressMessage("Design", "CA1065:Do not raise exceptions in unexpected locations", Justification = "<Pending>")]
public override object Value
{
get
Expand Down