Skip to content

Update README and metadata.json for 7.2.0-preview.1 release #14104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 3 commits into from
Nov 18, 2020
Merged

Update README and metadata.json for 7.2.0-preview.1 release #14104

adityapatwardhan merged 3 commits into from
Nov 18, 2020

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Nov 16, 2020 •
edited
Loading

PR Summary

Update README and metadata.json for 7.2.0-preview.1 release.
Changes to be noted:

  1. Add pv-ubuntu20
  2. Remove pv-winarm

PR Context

PR Checklist

iSazonov
iSazonov reviewed Nov 18, 2020
View reviewed changes
README.md
Comment on lines +100 to +102
[pv-debian9]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.9_amd64.deb
[pv-debian10]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.10_amd64.deb
[pv-debian11]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.11_amd64.deb
Copy link
Collaborator

@iSazonov iSazonov Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Ubuntu we sort versions from high to low :-)

Copy link
Member Author

@daxian-dbw daxian-dbw Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order doesn't matter. Those link references are not visible to users.

iSazonov
iSazonov reviewed Nov 18, 2020
View reviewed changes
README.md
Comment on lines +107 to +108
[pv-winx86-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x86.zip
[pv-winx64-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x64.zip
Copy link
Collaborator

@iSazonov iSazonov Nov 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put x64 on top as above for msi? (Swap line 107 and 108)

Copy link
Member Author

@daxian-dbw daxian-dbw Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order doesn't matter. Those link references are not visible to users.

iSazonov
iSazonov reviewed Nov 18, 2020
View reviewed changes
README.md
Comment on lines +111 to +112
[pv-arm32]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-arm32.tar.gz
[pv-arm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-arm64.tar.gz
Copy link
Collaborator

@iSazonov iSazonov Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

Copy link
Member Author

@daxian-dbw daxian-dbw Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 18, 2020
@daxian-dbw
Copy link
Member Author

daxian-dbw commented Nov 18, 2020

@adityapatwardhan I made a couple fixes. Can you please review again? Thanks!

@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.2 milestone Nov 18, 2020
@ghost ghost removed this from the 7.2.0-preview.2 milestone Nov 18, 2020
@ghost
Copy link

ghost commented Nov 18, 2020

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@adityapatwardhan adityapatwardhan merged commit 1b096de into PowerShell:master Nov 18, 2020
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.2 milestone Nov 18, 2020
@daxian-dbw daxian-dbw deleted the readme branch November 18, 2020 23:49
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

3 participants

@daxian-dbw @adityapatwardhan @iSazonov