Enable CA1000: Do not declare static members on generic types #14097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
Author
|
CI failures attributed to #14101. |
Contributor
Author
|
restarting tests |
Collaborator
|
The rule is enable for public members only. Since we have no complains we could force the rule to avoid breaking changes in public API in future. @xtqqczze Could you please check the rule for internal and private? |
Contributor
Author
|
4e28528 enables rule for internal and private too. |
iSazonov
approved these changes
Nov 18, 2020
iSazonov
added
CL-General
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/CA1000