Skip to content

Enable nullable: System.Management.Automation.Language.ISupportsTypeCaching #14088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Jan 9, 2021
Merged

Enable nullable: System.Management.Automation.Language.ISupportsTypeCaching #14088

iSazonov merged 1 commit into from
Jan 9, 2021

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Nov 13, 2020 •
edited
Loading

Tracking issue: #12631.

@ghost ghost assigned anmenaga Nov 13, 2020
xtqqczze
xtqqczze commented Nov 13, 2020
View reviewed changes
@xtqqczze xtqqczze marked this pull request as ready for review November 14, 2020 01:28
@xtqqczze xtqqczze requested a review from daxian-dbw as a code owner November 14, 2020 01:28
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 14, 2020

@xtqqczze We will move faster if we follow our plan - one type per PR without fixing usages of the type.

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 21, 2020
@ghost
Copy link

ghost commented Nov 21, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 23, 2020

ITypeName is in another PR - please remove.

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 23, 2020
@xtqqczze xtqqczze changed the title Enable nullable: System.Management.Automation.Language.ISupportsTypeCaching etc Enable nullable: System.Management.Automation.Language.ISupportsTypeCaching Nov 23, 2020
@xtqqczze xtqqczze force-pushed the nullable-ISupportsTypeCaching branch from 46fc9c9 to 64f699e Compare November 23, 2020 09:37
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 23, 2020

rebased to restrict changes to ISupportsTypeCaching

@xtqqczze xtqqczze mentioned this pull request Nov 23, 2020
Closed
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 23, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 30, 2020
@ghost
Copy link

ghost commented Nov 30, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 30, 2020

@powercode Can you review?

@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Jan 9, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov iSazonov merged commit 4480ee5 into PowerShell:master Jan 9, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 9, 2021
powercode
powercode reviewed Jan 13, 2021
View reviewed changes
Copy link
Collaborator

@powercode powercode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

+1 more reviewer

@powercode powercode powercode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @iSazonov @powercode @anmenaga