Skip to content

Enable IDE0075: SimplifyConditionalExpression #14078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 5 commits into from
Dec 2, 2020
Merged

Enable IDE0075: SimplifyConditionalExpression #14078

iSazonov merged 5 commits into from
Dec 2, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Nov 13, 2020

@ghost ghost assigned iSazonov Nov 13, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 16, 2020
@ghost ghost added the Stale label Dec 1, 2020
@ghost
Copy link

ghost commented Dec 1, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Dec 1, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 1, 2020 10:29
iSazonov
iSazonov reviewed Dec 1, 2020
View reviewed changes
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 1, 2020
xtqqczze and others added 2 commits December 1, 2020 15:29
@xtqqczze @iSazonov
Apply suggestions from code review
87fb236 
Remove unnecessary parenthesis.

Co-authored-by: Ilya <darpa@yandex.ru>
@xtqqczze
Fix formatting
a894572
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 1, 2020 •
edited
Loading

@iSazonov Ae you happy to merge as-is, or do you want more changes to remove redundant parenthesis?

@iSazonov iSazonov merged commit 18717c5 into PowerShell:master Dec 2, 2020
@xtqqczze xtqqczze mentioned this pull request Dec 2, 2020
Merged
14 tasks
@xtqqczze xtqqczze deleted the IDE0075 branch December 2, 2020 10:28
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@daxian-dbw daxian-dbw mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov