Move windows package signing to use ESRP #14060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
commented
Nov 12, 2020
TravisEz13
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
adityapatwardhan
requested changes
Nov 12, 2020
| type: github | ||
| endpoint: ComplianceGHRepo | ||
| name: PowerShell/compliance | ||
| ref: master |
Member
There was a problem hiding this comment.
I believe this is the default and it needs to be in ref/heads/master format
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/resources?view=azure-devops&tabs=schema#resources-repositories
Member
Author
There was a problem hiding this comment.
branch name works and I'm contantly having to add and remove this. I'd like to keep it for easier testing, and returning it back to it's default.
ghost
added
Waiting on Author
rjmholt
approved these changes
Nov 12, 2020
adityapatwardhan
approved these changes
Nov 13, 2020
adityapatwardhan
added
the
CL-BuildPackaging
|
🎉 Handy links: |
TravisEz13
added a commit
that referenced
this pull request
Dec 16, 2020
# Conflicts: # tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml
TravisEz13
added
BackPort-7.1.x-Done
TravisEz13
added a commit
that referenced
this pull request
Dec 16, 2020
# Conflicts: # tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml # Conflicts: # tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml
rjmholt
pushed a commit
to rjmholt/PowerShell
that referenced
this pull request
Jan 12, 2021
# Conflicts: # tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml # Conflicts: # tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml
|
🎉 Handy links: |
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Move windows package signing to use ESRP
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.