Skip to content

Enable IDE0062: MakeLocalFunctionStatic #14044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Nov 13, 2020
Merged

Enable IDE0062: MakeLocalFunctionStatic #14044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ dotnet_diagnostic.IDE0060.severity = silent
dotnet_diagnostic.IDE0061.severity = silent

# IDE0062: MakeLocalFunctionStatic
dotnet_diagnostic.IDE0062.severity = silent
dotnet_diagnostic.IDE0062.severity = warning

# IDE0063: UseSimpleUsingStatement
dotnet_diagnostic.IDE0063.severity = silent
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,7 @@ private void ParseExecutionPolicy(string[] args, ref int i, ref string? executio
private bool ParseFile(string[] args, ref int i, bool noexitSeen)
{
// Try parse '$true', 'true', '$false' and 'false' values.
object ConvertToBoolIfPossible(string arg)
static object ConvertToBoolIfPossible(string arg)
{
// Before parsing we skip '$' if present.
return arg.Length > 0 && bool.TryParse(arg.AsSpan().Slice(arg[0] == '$' ? 1 : 0), out bool boolValue)
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/DataStoreAdapterProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ internal string FullName
{
get
{
string GetFullName(string name, string psSnapInName, string moduleName)
static string GetFullName(string name, string psSnapInName, string moduleName)
{
string result = name;
if (!string.IsNullOrEmpty(psSnapInName))
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/parser/ast.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1414,7 +1414,7 @@ IEnumerable<ExperimentalAttribute> IParameterMetadataProvider.GetExperimentalAtt
}
}

ExperimentalAttribute GetExpAttributeHelper(AttributeAst attributeAst)
static ExperimentalAttribute GetExpAttributeHelper(AttributeAst attributeAst)
{
AttributeAst potentialExpAttr = null;
string expAttrTypeName = typeof(ExperimentalAttribute).FullName;
Expand Down