Skip to content

Revert changes to ComInterop #14012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Nov 9, 2020
Merged

Revert changes to ComInterop #14012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33fc384
Revert changes to ComInterop
xtqqczze Nov 8, 2020
74258de
Disable code analysis in ComInterop
xtqqczze Nov 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/System.Management.Automation/engine/ComInterop/.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
is_global = true

dotnet_analyzer_diagnostic.severity = none
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/ComInterop/ComInvokeBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ internal sealed class ComInvokeBinder
private readonly bool[] _isByRef;
private readonly Expression _instance;

private readonly BindingRestrictions _restrictions;
private BindingRestrictions _restrictions;

private VarEnumSelector _varEnumSelector;
private string[] _keywordArgNames;
Expand Down
10 changes: 5 additions & 5 deletions src/System.Management.Automation/engine/ComInterop/ExcepInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ namespace System.Management.Automation.ComInterop
[StructLayout(LayoutKind.Sequential)]
internal struct ExcepInfo
{
private readonly short _wCode;
private short _wCode;
private short _wReserved;
private IntPtr _bstrSource;
private IntPtr _bstrDescription;
private IntPtr _bstrHelpFile;
private readonly int _dwHelpContext;
private readonly IntPtr _pvReserved;
private readonly IntPtr _pfnDeferredFillIn;
private readonly int _scode;
private int _dwHelpContext;
private IntPtr _pvReserved;
private IntPtr _pfnDeferredFillIn;
private int _scode;

#if DEBUG
static ExcepInfo()
Expand Down