Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Nov 6, 2020

PR Summary

  • Make applicable private Guid fields readonly.
  • Use C# 7.2 in-modifier for passing a readonly Guid instead of ref-modifier (to fix compiler error).

PR Context

Follow-up to #13966.

PR Checklist

@ghost ghost assigned adityapatwardhan Nov 6, 2020
@xtqqczze xtqqczze marked this pull request as ready for review November 6, 2020 17:45
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 7, 2020

@xtqqczze Please resolve merge conflicts.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 8, 2020
@iSazonov iSazonov assigned iSazonov and unassigned adityapatwardhan Nov 8, 2020
@iSazonov iSazonov merged commit 093edbb into PowerShell:master Nov 8, 2020
@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze
Copy link
Contributor Author

We can follow-up after .Net 6.0 preview 1 now dotnet/runtime#44629 is merged.

@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants