Fix RCS1049: Simplify boolean comparison #13994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
iSazonov
reviewed
Nov 6, 2020
src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Nov 6, 2020
src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs
Outdated
Show resolved
Hide resolved
|
Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a |
iSazonov
added
the
CL-CodeCleanup
Co-authored-by: Ilya <darpa@yandex.ru>
iSazonov
approved these changes
Nov 7, 2020
Contributor
Author
|
This PR makes changes to ComInterop, so a corresponding PR has been opened at dotnet/runtime#44564. |
Contributor
Author
|
dotnet/runtime#44564 is approved. |
iSazonov
approved these changes
Nov 12, 2020
Contributor
Author
|
dotnet/runtime#44564 is merged. |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md
This PR includes changes to ComInterop that have also been made in dotnet/runtime#44564.