Add IDE analyzer rule IDs to comments #13960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
Author
|
@iSazonov Could you merge? |
Contributor
Author
|
|
Collaborator
|
@xtqqczze can you add a description to this PR as right now this to me doesn't explain why this should be merged, there is no link to an issue etc so there is no context to this PR other than what is in files changed - a recommended best practice for when raising a PR |
iSazonov
approved these changes
Nov 2, 2020
Collaborator
|
@xtqqczze Please resolve merge conflicts. |
xtqqczze
force-pushed
the
globalconfig-comments
branch
from
3213040 to
eb8c5c8
Compare
Contributor
Author
|
@iSazonov rebased, can you merge soon to avoid more merge conflicts |
iSazonov
added
the
CL-CodeCleanup
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #13835.