Skip to content

Enable IDE0036: OrderModifiers #13958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Nov 2, 2020
Merged

Enable IDE0036: OrderModifiers #13958

iSazonov merged 1 commit into from
Nov 2, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 31, 2020 •
edited
Loading

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036

Follow-up to #13881, after EnforceCodeStyleInBuild was enabled in #13957.

@ghost ghost assigned anmenaga Oct 31, 2020
@xtqqczze xtqqczze mentioned this pull request Oct 31, 2020
Merged
@xtqqczze

This comment has been minimized.

Sign in to view
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 31, 2020

closing and reopening to restart tests

@xtqqczze xtqqczze closed this Oct 31, 2020
@xtqqczze xtqqczze reopened this Oct 31, 2020
@xtqqczze xtqqczze changed the title WIP: Enable IDE0036: OrderModifiers p2 Enable IDE0036: OrderModifiers p2 Nov 1, 2020
@xtqqczze xtqqczze marked this pull request as ready for review November 1, 2020 19:51
@xtqqczze xtqqczze changed the title Enable IDE0036: OrderModifiers p2 Enable IDE0036: OrderModifiers Nov 2, 2020
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 2, 2020
@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Nov 2, 2020
@iSazonov iSazonov merged commit fc15daa into PowerShell:master Nov 2, 2020
@xtqqczze xtqqczze deleted the IDE0036-p2 branch November 2, 2020 03:38
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @anmenaga