Skip to content

Enforce code style in build #13957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
Nov 1, 2020
Merged

Enforce code style in build #13957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f5c6d8
Enable EnforceCodeStyleInBuild
xtqqczze Oct 31, 2020
fb29f19
Disable rules breaking build
xtqqczze Oct 31, 2020
d61221c
Disable IDE0036
xtqqczze Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,7 @@ dotnet_diagnostic.IDE0034.severity = silent
dotnet_diagnostic.IDE0035.severity = silent

# OrderModifiers
dotnet_diagnostic.IDE0036.severity = warning
dotnet_diagnostic.IDE0036.severity = suggestion

# UseInferredMemberName
dotnet_diagnostic.IDE0037.severity = silent
Expand Down Expand Up @@ -868,7 +868,7 @@ dotnet_diagnostic.IDE0046.severity = silent
dotnet_diagnostic.IDE0047.severity = silent

# AddRequiredParentheses
dotnet_diagnostic.IDE0048.severity = warning
dotnet_diagnostic.IDE0048.severity = suggestion

# PreferBuiltInOrFrameworkType
dotnet_diagnostic.IDE0049.severity = silent
Expand Down Expand Up @@ -943,7 +943,7 @@ dotnet_diagnostic.IDE0071.severity = silent
dotnet_diagnostic.IDE0072.severity = silent

# FileHeaderMismatch
dotnet_diagnostic.IDE0073.severity = warning
dotnet_diagnostic.IDE0073.severity = suggestion

# UseCoalesceCompoundAssignment
dotnet_diagnostic.IDE0074.severity = silent
Expand Down
4 changes: 4 additions & 0 deletions PowerShell.Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,4 +157,8 @@
<PropertyGroup>
<Features>strict</Features>
</PropertyGroup>

<PropertyGroup>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
</PropertyGroup>
</Project>
4 changes: 4 additions & 0 deletions test/Test.Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
<Features>strict</Features>
</PropertyGroup>

<PropertyGroup>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
</PropertyGroup>

<PropertyGroup Condition=" '$(IsWindows)' != 'true' ">
<DefineConstants>$(DefineConstants);UNIX</DefineConstants>
</PropertyGroup>
Expand Down