Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Oct 30, 2020

PR Summary

Due to some changes with how reparse points are handled, you can no longer execute a native command directly from an SMB share because the new code tries to find the target of the reparse point, but that isn't a valid call for SMB so it fails with an unhandled exception. Fix is to check in the function to find the reparse target if the last error is ERROR_INVALID_FUNCTION which indicates it's not a reparse point and it will use the original file path for execution.

Validated manually against \live.sysinternals.com\tools\procdump

PR Context

PR Checklist

@SteveL-MSFT
Copy link
Member Author

CodeFactor issues are not related to this change

@iSazonov
Copy link
Collaborator

Should we fix private static string WinInternalGetLinkType(string filePath) too?

@SteveL-MSFT SteveL-MSFT changed the title Fix native command execution to work on SMB share Fix native command execution to work from SMB share Oct 31, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 1, 2020

@SteveL-MSFT Sorry, I forget about #13634. Please see the discussion. It seems we find a better consensus there.

@SteveL-MSFT
Copy link
Member Author

Looks like this is dupe of #13634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants