Fix native command execution to work from SMB share #13947
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Due to some changes with how reparse points are handled, you can no longer execute a native command directly from an SMB share because the new code tries to find the target of the reparse point, but that isn't a valid call for SMB so it fails with an unhandled exception. Fix is to check in the function to find the reparse target if the last error is ERROR_INVALID_FUNCTION which indicates it's not a reparse point and it will use the original file path for execution.
Validated manually against \live.sysinternals.com\tools\procdump
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.