Skip to content

Enable CA1012: Abstract types should not have public constructors #13940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Nov 21, 2020
Merged

Enable CA1012: Abstract types should not have public constructors #13940

iSazonov merged 1 commit into from
Nov 21, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 30, 2020

@iSazonov iSazonov requested a review from PaulHigin October 30, 2020 07:31
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 30, 2020
PaulHigin
PaulHigin approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtqqczze

This comment has been minimized.

Sign in to view
@xtqqczze

This comment has been minimized.

Sign in to view
@xtqqczze xtqqczze closed this Oct 31, 2020
@xtqqczze xtqqczze reopened this Oct 31, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 10, 2020
@ghost
Copy link

ghost commented Nov 10, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 21, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 21, 2020
@ghost ghost removed this from the 7.2.0-preview.2 milestone Nov 21, 2020
@ghost
Copy link

ghost commented Nov 21, 2020

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@iSazonov iSazonov merged commit 60643e2 into PowerShell:master Nov 21, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 21, 2020
@xtqqczze xtqqczze deleted the CA1012 branch November 21, 2020 23:09
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @PaulHigin @iSazonov @adityapatwardhan