Skip to content

Fix CA1003: Use generic event handler instances #13937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Nov 7, 2020
Merged

Fix CA1003: Use generic event handler instances #13937

iSazonov merged 1 commit into from
Nov 7, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 30, 2020 •
edited
Loading

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1003

This PR does not contain code fixes for public API surfaces, so the changes should not be breaking.

@ghost ghost assigned daxian-dbw Oct 30, 2020
@xtqqczze xtqqczze marked this pull request as ready for review October 30, 2020 01:12
iSazonov
iSazonov reviewed Oct 30, 2020
View reviewed changes
@iSazonov iSazonov requested a review from PaulHigin October 30, 2020 07:30
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 30, 2020
PaulHigin
PaulHigin approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 7, 2020
@ghost
Copy link

ghost commented Nov 7, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Nov 7, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 7, 2020
@iSazonov iSazonov merged commit 2e24380 into PowerShell:master Nov 7, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 7, 2020
@xtqqczze xtqqczze deleted the CA1003 branch November 7, 2020 16:23
@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @PaulHigin @iSazonov @daxian-dbw